Support » Plugin: List category posts » Update spits out code

  • Resolved myblogisgreat

    (@myblogisgreat)


    Hi,
    The latest update prints out lots of code in the top of the webpage.
    De-activating the plugin goes back to normal again.

    Screen shot:
    2017-11-29_0748

    Kind regards
    Themis

Viewing 14 replies - 16 through 29 (of 29 total)
  • Please downgrade this plugin as soon as possible.

    Thanks

    • This reply was modified 1 year, 5 months ago by  abhayplt.
    Plugin Author Fernando Briano

    (@fernandobt)

    I’m debugging the issue, trying to find out why this is happening. In the meantime, you can download the previous version here:
    https://downloads.wordpress.org/plugin/list-category-posts.0.73.2.zip

    I’ll release a bug fix release as soon as I find out what’s going on and am able to fix it.

    Plugin Author Fernando Briano

    (@fernandobt)

    Version 0.74.1 is out. I think I found the issue and hopefully this update fixes it for everyone here. Please let me know if it does!

    Hi Fernando,

    I’d like you to know we all appreciate you and your hard work and contributing such a great plugin to our community.

    For my site I’ve rolled back to 0.73.2 and everything is fine and can wait till you have a fix.

    Many thanks,

    Roger

    Still the same problem:

    show_pagination($params['pagination'])){ $lcp_paginator = ''; $pages_count = ceil ( $params['posts_count'] / # Avoid dividing by 0 (pointed out by @rhj4) max( array( 1, $params['numberposts'] ) ) ); $pag_output = ''; if ($pages_count > 1){ for($i = 1; $i <= $pages_count; $i++){ $lcp_paginator .= $this->lcp_page_link($i, $params['page'], $params['instance']); } $pag_output .= "
    "; // Add "Previous" link if ($params['page'] > 1){ $this->prev_page_num = intval(intval($params['page']) - 1); $pag_output .= $this->lcp_page_link($this->prev_page_num , $params['page'], $params['instance'], $params['previous'] ); } $pag_output .= $lcp_paginator; // Add "Next" link if ($params['page'] < $pages_count){ $this->next_page_num = intval($params['page'] + 1); $pag_output .= $this->lcp_page_link($this->next_page_num, $params['page'], $params['instance'], $params['next']); } $pag_output .= "
    "; } return $pag_output; } } // <code>char</code> is the string from pagination_prev/pagination_next private function lcp_page_link($page, $current_page, $lcp_instance, $char = null){ $link = ''; if ($page == $current_page){ $link = "
    $current_page
    "; } else { $server_vars = add_magic_quotes($_SERVER); $request_uri = $server_vars['REQUEST_URI']; $query = $server_vars['QUERY_STRING']; $amp = ( strpos( $request_uri, "?") ) ? "&" : ""; $pattern = "/[&|?]?lcp_page" . preg_quote($lcp_instance) . "=([0-9]+)/"; $query = preg_replace($pattern, '', $query); $url = strtok($request_uri,'?'); $protocol = "http"; $port = $server_vars['SERVER_PORT']; if ( (!empty($server_vars['HTTPS']) && $server_vars['HTTPS'] !== 'off') || $port == 443){ $protocol = "https"; } $http_host = $server_vars['HTTP_HOST']; $page_link = "$protocol://$http_host$url?$query" . $amp . "lcp_page" . $lcp_instance . "=". $page . "#lcp_instance_" . $lcp_instance; $link .= "
    prev_page_num) { $link .= "class='lcp_prevlink'"; } elseif ($page === $this->next_page_num) { $link .= "class='lcp_nextlink'"; } $link .= ">"; ($char != null) ? ($link .= $char) : ($link .= $page); $link .= "
    "; } // WA: Replace '?&' by '?' to avoid potential redirection problems later on $link = str_replace('?&', '?', $link ); return $link; } }

    0.74.1

    Update Failed: <? /** * Class to build pagination * @author fernando@picandocodigo.net */ class LcpPaginator { private $catlist; private $prev_page_num; private $next_page_num; // Singleton implementation private static $instance = null; public static function get_instance(){ if( !isset( self::$instance ) ){ self::$instance = new self; } return self::$instance; } # Define if pagination should be displayed based on ‘pagination’ param and option. # Check if the pagination option is set to true, and the param # is not set to ‘no’ (since shortcode parameters should # override general options). # Receives params[‘pagination’] from CatList private function show_pagination($pagination){ return !empty($pagination) && $pagination == ‘yes’ || (get_option(‘lcp_pagination’) === ‘true’ && ($lcp_pag_present && $pagination !== ‘false’) ); } public function get_pagination($params){ if ($this->show_pagination($params[‘pagination’])){ $lcp_paginator = ”; $pages_count = ceil ( $params[‘posts_count’] / # Avoid dividing by 0 (pointed out by @rhj4) max( array( 1, $params[‘numberposts’] ) ) ); $pag_output = ”; if ($pages_count > 1){ for($i = 1; $i <= $pages_count; $i++){ $lcp_paginator .= $this->lcp_page_link($i, $params[‘page’], $params[‘instance’]); } $pag_output .= “”; // Add “Previous” link if ($params[‘page’] > 1){ $this->prev_page_num = intval(intval($params[‘page’]) – 1); $pag_output .= $this->lcp_page_link($this->prev_page_num , $params[‘page’], $params[‘instance’], $params[‘previous’] ); } $pag_output .= $lcp_paginator; // Add “Next” link if ($params[‘page’] < $pages_count){ $this->next_page_num = intval($params[‘page’] + 1); $pag_output .= $this->lcp_page_link($this->next_page_num, $params[‘page’], $params[‘instance’], $params[‘next’]); } $pag_output .= “”; } return $pag_output; } } // char is the string from pagination_prev/pagination_next private function lcp_page_link($page, $current_page, $lcp_instance, $char = null){ $link = ”; if ($page == $current_page){ $link = “$current_page”; } else { $server_vars = add_magic_quotes($_SERVER); $request_uri = $server_vars[‘REQUEST_URI’]; $query = $server_vars[‘QUERY_STRING’]; $amp = ( strpos( $request_uri, “?”) ) ? “&” : “”; $pattern = “/[&|?]?lcp_page” . preg_quote($lcp_instance) . “=([0-9]+)/”; $query = preg_replace($pattern, ”, $query); $url = strtok($request_uri,’?’); $protocol = “http”; $port = $server_vars[‘SERVER_PORT’]; if ( (!empty($server_vars[‘HTTPS’]) && $server_vars[‘HTTPS’] !== ‘off’) || $port == 443){ $protocol = “https”; } $http_host = $server_vars[‘HTTP_HOST’]; $page_link = “$protocol://$http_host$url?$query” . $amp . “lcp_page” . $lcp_instance . “=”. $page . “#lcp_instance_” . $lcp_instance; $link .= “prev_page_num) { $link .= “class=’lcp_prevlink'”; } elseif ($page === $this->next_page_num) { $link .= “class=’lcp_nextlink'”; } $link .= “>”; ($char != null) ? ($link .= $char) : ($link .= $page); $link .= “”; } // WA: Replace ‘?&’ by ‘?’ to avoid potential redirection problems later on $link = str_replace(‘?&’, ‘?’, $link ); return $link; } }{“success”:true,”data”:{“update”:”plugin”,”slug”:”list-category-posts”,”oldVersion”:”Version 0.74″,”newVersion”:”Version 0.74.1″,”plugin”:”list-category-posts\/list-category-posts.php”,”pluginName”:”List category posts”}}

    Plugin Author Fernando Briano

    (@fernandobt)

    rogerhyam,
    Is this an issue with WordPress’ plugin updating system itself? The code from the plugin that you pasted belong to the previous version:
    <? /** * Class to build pagination * @author fernando@picandocodigo.net */ class LcpPaginator
    Has been changed to:
    <?php /** * Class to build pagination * @author fernando@picandocodigo.net */ class LcpPaginator
    Apparently you need to change some setup to your php.ini file to allow php files to start with just <? instead of <?php. I changed it to <?php in version 0.74.1 to keep compatibility.

    Everyone else, if you can please post your logs that would be really helpful to try and find out what’s wrong. As I said, I can’t see the error on my blogs, so I haven’t completely figured out what’s wrong yet. More info on debugging.

    The new 0.74.1 works excellent here now!
    Super-duper, many thanks for your fast help!!
    Best regards
    themmi

    • This reply was modified 1 year, 5 months ago by  myblogisgreat.
    • This reply was modified 1 year, 5 months ago by  myblogisgreat.

    Version 0.74.2 is working OK for me, on 4 sites.
    I upgraded from 0.73.2 direct to 0.74.2

    Some of the 4 sites are on WP 4.9 and others on WP 4.8.3

    Plugin Author Fernando Briano

    (@fernandobt)

    Thanks @myblogisgreat and @abcdiamond! I’m marking this issue as resolved for now since there hasn’t been any reply from the rest. If anyone’s still having issues, please open a new issue.

    Thanks everyone for your feedback and patience!

    0.74.2 is working great for me now.

    Thanks for the speedy fix.

    Roger

    0.74.2 work very well on all my websites.
    Your work is very good! Thanks a lot.

    I just noticed this problem, and like the author, when I deactivate the plugin the error message comes back… https://www.suesutcliffe.com/hosting/

    My hosting company wrote…

    from the looks of this one error, there seems to be an issue with the plugin List category posts. Line 30 reads ” ($lcp_pag_present &&” which looks like it is attempting to join something, but I don’t know this plugin enough to fix the issue. All I can suggest is reaching out to Fernando at the WordPress Support for the plugin: https://en-ca.wordpress.org/plugins/list-category-posts/

    I use this plugin in many spots and have recommended it to many, so removing it is a big problem I don’t need today. Is someone able to help quickly, or should I have everyone deactivate the plugin?

    My webmaster turned off WordPress debug mode and this error message no longer appears. I had’t realized it was on. Thank you @zymeth25

Viewing 14 replies - 16 through 29 (of 29 total)
  • The topic ‘Update spits out code’ is closed to new replies.