Update feed source not working with WP-Cron Control

  • Resolved julezvdb

    (@julezvdb)


    9 years ago

    WP-Cron Control is a tool to make wp cron work separate from page hits (page hits don’t trigger the jobs, making a page loads faster), instead WP-Cron Control allows crontabs to trigger the wp cron through a wget or php command.

    Since WPRSS relies heavily on cronjobs to fetch it’s feed items, this is plugin is a go-to solution for many people with heavy site traffic and a lot of feeds. WP-Cron Control has been serving me well for over 2 years now and has 6,000+ active installs.

    Steps to reproduce:

    1. Install WP-Cron Control and configure it to work with a secret url
    2. Install WPRSS
    3. Add a number of feeds through the importer (feed_title,http://feed.url/feed/)
    4. Let the feeds fetch per cron job
    5. Click on Feed Sources in backend
    6. Edit a feed you imported.
    7. Try to edit it: remove something from the URL or add /feed/
    8. Click Save
    9. Page refreshed and nothing you just changed in the feed source url field was saved, but WPRSS tells you the feed was updated (it wasn’t)

    Notes:

    • using last version of WP and WPRSS and WP-Cron Control (as of this writing)
    • not purchased any premium addons
    • not messed with the code of the plugin
    • WPRSS is working with a couple dozen other plugins, disable them all, and still not saving
    • server highly capable of managing memory, CPU, bandwidth wise.

    https://wordpress.org/plugins/wp-rss-aggregator/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Thread Starter julezvdb

    (@julezvdb)

    9 years ago

    Also posted here:
    https://wordpress.org/support/topic/update-feed-source-not-working-with-wp-cron-control?replies=2

    Plugin Author Mark Zahra

    (@markzahra)

    9 years ago

    Hi, Sorry but I haven’t understood exactly what’s going on. What’s the issue exactly? Can you explain what’s going wrong with our plugin in particular please? Thanks.

    Thread Starter julezvdb

    (@julezvdb)

    9 years ago

    Hi Mark

    Please use the steps above on a clean WP install and you will see that imported feed sources can not be saved while the WP Cron Control plugin is active.

    Deactivating the WP Cron Control plugin will cause the WPRSS to function normally again.

    Either: list the plugin as a conflicting plugin on your support page (and please provide an alternative for sites that have a lot of feeds and want to import feeds with a cron job triggered wp cron, rather than the page-vistit triggered cron.

    Or, contact the plugin author of the other plugin and find a solution with them (either one of you is defining same-named classes or functions, I’d imagine).

    doytch

    (@doytch)

    9 years ago

    Hi there,
    I’ve debugged this and found the issue to be that we check whether the cron is currently executing before saving feed source data. We check that using the WordPress DOING_CRON global. WP-Cron Control sets that global to be permanently true. The reason we don’t save feed source data while the cron is executing is as follows.

    Consider the situation where a feed source’s import process has started and a user then edits that feed source’s settings. The rest of the import process will be done using the new settings, so the behaviour is fully unpredictable. We check for invalid situations and values at the start of the import process but this allows another vector for introducing invalid values.

    I’ll be looking at this to see if we can handle this in another way, but in the meantime, you can remove this check by commenting out line 306 here.

    Hope that helps.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Update feed source not working with WP-Cron Control’ is closed to new replies.