Update breaks websites

  • Resolved amityweb

    (@amityweb)


    8 years, 4 months ago

    Your latest update results in internal server errors. This is because you changed array() to []. Why on earth would you do that, and thus break any website using your plugin on PHP <5.3? There is no difference in the tags, [] are just short tags. Such careless changes is devastating to websites that keep their plugins up to date, our site was down for over 30 minutes while we figure this out, and have to update your plugin for backward compatibility, and now have to exclude it from updates.

    If you want to use shortags do it on a new plugin and specify PHP 5.4+ only. Its complete carelessness do introduce PHP 5.4+ only code into well used plugins many of which would still be used on PHP <5.4

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Sarah Anderson

    (@sarahg111)

    8 years, 4 months ago

    Hi there, apologies for the time you lost on this. If you use the previous version then it will continue to work on PHP 5.3 and I will update the description to mention this.

    I updated all of the code for various reasons and as 5.3 was ended over 2.5 years ago it wasn’t necessarily something I’d considered as I’ve worked on 5.6+ for quite a while now. This is how I code and when rewriting it I wrote it how I code day in day out.

    I will add in a PHP version check also to ensure that no one else misses the version comment.

    Plugin Author Sarah Anderson

    (@sarahg111)

    8 years, 4 months ago

    Instead of adding in a PHP version check, I’ve updated the code to allow for backwards compatibility to PHP 5.3 so that you can run the latest changes on older versions.

    I’m having issues committing it to the repository right now but if you want to try out the new version you can download it from GitHub – https://github.com/SarahA21/WP-PageMenuEditor/releases

    I should get this online tonight when on my own laptop rather than at work.

    Plugin Author Sarah Anderson

    (@sarahg111)

    8 years, 4 months ago

    Just to confirm the new update is now live on the WordPress repository.

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Update breaks websites’ is closed to new replies.