Support » Plugin: The Events Calendar » Untranslated strings in php

Untranslated strings in php

  • Resolved Erpol

    (@erpol53)


    3 years, 7 months ago

    Hi,

    I came upon 3 untranslated strings in : /src/views/modules/bar.php

    These are:

    					
data-label-hidden="<?php printf( esc_html__( 'Show %s Search', 'the-events-calendar' ), tribe_get_event_label_plural() ); ?>"
data-label-shown="<?php printf( esc_html__( 'Hide %s Search', 'the-events-calendar' ), tribe_get_event_label_plural() ); ?>"
>
<span class="tribe-bar-toggle-text">
<?php printf( esc_html__( 'Show %s Search', 'the-events-calendar' ), tribe_get_event_label_plural() ); ?>
</span>

    This is fairly recent from one of the latest updates, the code didn’t exist in a late October version. I checked the corresponding po file (for French) of course, but the original strings are not in it.

    I solved the immediate issue by changing the php, but it’s not very elegant or recommended!

    Thanks,

    RP

    • This topic was modified 3 years, 7 months ago by Erpol.
Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Sky Shabatura

    (@skyshab)

    3 years, 7 months ago

    Hi there,

    If there are not translations available for certain items in your language, you can add them on your site. You can also submit the missing translations to be included on our end.

    For more information, check out this article: https://theeventscalendar.com/knowledgebase/translating-the-events-calendar/

    Hope that helps!
    Sky

    Thread Starter Erpol

    (@erpol53)

    3 years, 7 months ago

    Hi,

    I think I didn’t express myself clearly – it’s not the translations that are missing (that’s easy to fix), but it’s the original strings that are not in the po file.

    Regards,
    RP

    Plugin Author Sky Shabatura

    (@skyshab)

    3 years, 7 months ago

    Hi again,

    Looking deeper into this, it appears that the translation file was not updated with the last few plugin releases. I have flagged this with the team, and we will update this with the next release.

    Thanks for bringing this to our attention.

    Sky

    Thread Starter Erpol

    (@erpol53)

    3 years, 7 months ago

    Hi,

    Great, thanks!

    I’ll keep on the lookout for the fix in next updates, but until it’s fixed I’ll have to keep my hack 🙁
    It’s fortunate that you give the possibility to put the source file safely in my child theme, so it’s not overwritten.

    Cheers,

    RP

    Ed

    (@erishel)

    3 years, 6 months ago

    Hey @erpol53,

    Can you verify if this these translations were added in the latest release?

    Take care,
    Ed 🤟

    Thread Starter Erpol

    (@erpol53)

    3 years, 6 months ago

    Hi,

    Yes, the good news is that the original strings are in the latest version’s .po files, and are translated in French!

    The bad news is that the translation (I’m speaking only about French here) is wrong: You can’t say “Show event search”, you need to say “Show search of events”.
    So the french strings should be:
    “Afficher la Recherche d’%s” and “Masquer la Recherche d’%s”, which would give:
    “Afficher la Recherche d’Evènements” and “Masquer la Recherche d’Evènements”.

    I fixed this in my .po file

    Thanks for the quick reaction,

    RP

    Ed

    (@erishel)

    3 years, 6 months ago

    Glad that the update helped!

    If you’d like, you can contribute and offer the corrected versions on the community translations project > https://translate.wordpress.org/projects/wp-plugins/the-events-calendar/stable

    Take care,
    Ed 🤟

    Ed

    (@erishel)

    3 years, 5 months ago

    Hey there,

    Since this topic has been inactive for a while, I’m going to go ahead and mark as resolved. Don’t hesitate to reopen or create a new topic if you still need help! 😄

    Take care,
    Ed 🤟

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Untranslated strings in php’ is closed to new replies.

Topic Tags

Views