Unnecessary styles in admin area

  • Resolved m_i_n

    (@m_i_n)


    9 years, 9 months ago

    Is it necessary for the plugin to print in the whole admin area the following styles? 

    label{
	padding-bottom:5px;
	font-weight:bold;
	margin-left:10px;
}
.success{
	background-color:#CF9 !important;
	border:1px solid #903 !important;
}

    Such general selector as ‘label’ affects whole admin area – often destroys styles of WP options and other components.

    https://wordpress.org/plugins/wp-google-map-plugin/

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Flipper Code

    (@flippercode)

    9 years, 9 months ago

    Hello,

    This’ll not affect your other part of the admin because we’re loading scripts only on the plugin’s own pages.

    add_action(‘load-‘.$pagehook_name_here, ‘call_function_here’);

    Thanks

    Thread Starter m_i_n

    (@m_i_n)

    9 years, 9 months ago

    I wouldn’t report issue, if that would be the case. Unfortunately, those styles DO affect whole dashboard (it’s printed everywhere). Please have a look:

    http://snag.gy/Wffno.jpg

    You can visit for example Settings / Reading and see in the HTML code.
    Disabling the plugin makes it back to normal.

    Plugin Author Flipper Code

    (@flippercode)

    9 years, 9 months ago

    that’s a strange for me also. we’ll take an action on it and will update the plugin. Thanks for your information about the plugin.

    Thread Starter m_i_n

    (@m_i_n)

    9 years, 9 months ago

    Thank you.

    BTW, to be safe (except adding styles only if needed), I recommend to wrap it all with a container, and use selectors like:

    .my-plugin-container label { ... }

    Thread Starter m_i_n

    (@m_i_n)

    9 years, 8 months ago

    I can see you’ve fixed in 2.3.5 unnecessary code on every admin page, but one file (http://snag.gy/eqtsF.jpg) still affects WordPress messages. You can see it in the previous screen – “Settings saved” box.

    Plugin Author Flipper Code

    (@flippercode)

    9 years, 8 months ago

    Hello,

    Thanks for your very depth attention towards the plugin and we’re taking care of these changes. Something else, Do you do freelance work too? we need someone like you who can take a close look on our all plugins and do programming for it’s customization.

    Thanks

    Plugin Author Flipper Code

    (@flippercode)

    9 years, 7 months ago

    I hope all issues are solved. Please open a new thread if you have any question.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Unnecessary styles in admin area’ is closed to new replies.

Tags