Support » Plugin: WP YouTube Lyte » Unmatched End Tag

  • Resolved Anonymous User 14978628

    (@anonymized-14978628)


    Hey Frank,

    I’m trying to diagnose and issue on Edge and wanted to rule something out.

    Edge console tells me there is an “unmatched end tag” and this appears to be in the code output by this plugin. Is there anyway to fix this?

    <p style="text-align: center;"><div class="lyte-wrapper" style="width:853px;max-width: 100%;margin:5px auto;"><div class="lyMe" id="WYL_nTnXI7uZbI0" itemprop="video" itemscope itemtype="http://schema.org/VideoObject"><meta itemprop="thumbnailUrl" content="https://i.ytimg.com/vi/nTnXI7uZbI0/hqdefault.jpg" /><meta itemprop="embedURL" content="http://www.youtube.com/embed/nTnXI7uZbI0" /><meta itemprop="uploadDate" content="2017-09-14T15:53:28.000Z" /></p>

    Specifically, Edge is highlighting the closing paragraph tag as the issue, but not sure why that would be as it looks to be closing the p style tag

    </p>

Viewing 15 replies - 16 through 30 (of 30 total)
  • Thread Starter Anonymous User 14978628

    (@anonymized-14978628)

    ok, i will test this again. I did the test on my local install so don’t have any caching there.

    Thread Starter Anonymous User 14978628

    (@anonymized-14978628)

    I’m still getting the error. The previous page you mentioned on your site didn’t have the error, but this page still does:

    https://blog.futtta.be/2017/09/06/music-from-our-tube-aimee-mann-live-on-kexp/

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    The page cache was fooling you on the Aimee Mann page, look at https://blog.futtta.be/2017/09/06/music-from-our-tube-aimee-mann-live-on-kexp/?ao_noptimize=1 (the query-string param stops the page from being served from cache AND stops autoptimize from making things harder to read) and you’ll see all is all right πŸ™‚

    Thread Starter Anonymous User 14978628

    (@anonymized-14978628)

    On my local install i have wordpress 4.8.4 installed due to theme incompatibility with latest version. Could that be why i’m not seeing a change?

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    could be, haven’t tested against that version I’m afraid.

    Thread Starter Anonymous User 14978628

    (@anonymized-14978628)

    ok, well if you think the issue is fixed go ahead and release the update to wordpress. I’ll update it on my production site and let you know.

    Thread Starter Anonymous User 14978628

    (@anonymized-14978628)

    Tested master on my site. Still get unmatched end tag warning.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    that seems to be just your own (theme’s) p used to center the vid Marty, cfr. https://i.imgur.com/FXpNoGH.png, as you can see in the screenshot all wpautop-added p’s are indeed gone.

    Thank a lot for your work, the p tags and display problems disappeared on my website. For your information, my WP version is the last one.

    Thread Starter Anonymous User 14978628

    (@anonymized-14978628)

    Hey Frank, Thanks for the screenshot. This might be due to my theme then, as even removing the center alignment i still get the p tag appearing. Will have to dive into this a bit deeper, but it appears from all comments that this issue has been fixed.

    Thread Starter Anonymous User 14978628

    (@anonymized-14978628)

    Wow, just discovered a major problem with the master copy of YouTubeLyte. It removed all the <p> tags from my posts so my formatting is completely gone. Fortunately, using the previous version puts everything back to normal!

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    well, afraid it’s that OR living with the unmatched tags I’m afraid; the <p> tags are added by WordPress core, but mess up Lyte’s code (as you noticed).

    you can keep on using the “github master” version of Lyte and force it to not disable wpautop by adding

    add_filter('lyte_remove_wpautop','__return_false');

    OR you can add p-tags around your paragraphs yourself, rendering wpautop useless(er).

    only question remaining (for lyte); should it by default stop wpautop, or should it leave it be except when a filter is called?

    frank

    Thread Starter Anonymous User 14978628

    (@anonymized-14978628)

    I would say leave it as be. P tag issue was never a big problem from what i could see.

    If it caused this issue on my theme it could happen with others, and this could freak people out seeing their paragraph formatting completely disappear. It left me with large blocks/walls of text.

    Have the option for a filter, sure, but enabling this by default seems like a bad idea.

    Can i just check, this didn’t make any permanent changes to my site right? I mean reverting to previous version/disabling plugin puts things back to default settings?

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    nothing permanent no πŸ™‚

    I’ll invert the filter to only stop wpautop if activated explicitely.

    frank

    Plugin Author Frank Goossens

    (@futtta)

    So 1.6.8 which was released 2 days contains that filter. Thanks for all the feedback @martychc23 and @joanr70.

    Enjoy your Friday!
    frank

Viewing 15 replies - 16 through 30 (of 30 total)
  • The topic ‘Unmatched End Tag’ is closed to new replies.