Well, HTML validation warnings are trivial fixes, so I’ve prepared an update to address your concerns. Did you have any particular concerns other than the use of <style> in <body>, a couple of missing alt tags, and the one URL that had unescaped ampersands?
You can see the changes here and here. The admin page won’t necessarily validate because of user settings (WordPress core doesn’t anyway), but the frontend should be just fine now.
I’m still using the plugin. I ended up removing the generated code and harcoding it to a css file. also changes the ampersands like you did on your new code, validation in the backoffice is unnecessary. I’m glad you so proptly fixed it, sorry for the bad temper.
It would be helpfull if you splitted your code into smaller logic packs and maybe instead of dropping a style inside body printing a css file from the backoffice at save time and loading it to wp_head hook. just an Idea.
Best Regards
X
I do need to do a lot more cleanup and segmenting of the code; this was my first plugin so I’ve been cleaning it up as I learn more. I’ve also thought about running through all of the css and storing it in the backend, then just pulling it into the admin; I’ll probably try implementing that now too because it should be trivial.
Anyway, I’ll push the update tomorrow after I have time to thoroughly test everything.
Ok, good luck, drop me a note here so I can test it too and give you some feedback. Keep up the good work. Keep it clean a simple to use and i’m sure it will become a great plugin.
Okay, I’ve finished up everything for the next minor release, focusing on cleanup/efficiency. Could obviously use a lot more, but I know a huge chunk of code is coming out soon anyway, so I don’t want to get into that stuff (everything relating to the link settings).
The trunk version contains all of these changes. Let me know if you have any suggestions or find any bugs! It seems to be working fine in my testing, but it’s easy to miss things. I decided to store all of the output in the db instead of a separate file to avoid the extra http request.
Ok I’ll try these with my new client website.
I’ll let you know if I find anything.
Best Regards.
Since the original issues have been resolved, could you please update your review? And if you see outstanding issues, please let me know.
Thanks.
