• Resolved KTS915

    (@kts915)


    I am using the excellent s2Member plugin: https://wordpress.org/plugins/s2member/

    One of the things that does is add a number of columns to the Users admin page. As soon as I activate Sprout Invoices, the fields within those columns go blank. The columns remain, but no data is visible. (It hasn’t been lost.) Any idea on how to get the columns to show the intended data, please?

    So that’s the first niggle. The second is that, when I deactivate Sprout Invoices — obviously, a necessary step to debug something like the above issue — I get a message asking me for feedback. Honestly, I really don’t want that every few minutes while I get to know th plugin! Is there a way to turn that off?

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Dan Cameron

    (@dancameron)

    I’ll need to test s2Member out next week, however knowing a little bit about that plugin I would guess that it’s not doing things the WordPress way.

    As for the other problem, it’s not possible to turn off. I will talk to the service that runs that service though, maybe they can determine who’s already uninstalled before asking again.

    Have a great weekend.

    PS: If you don’t hear from me about the user issue by the end of Monday please bother me about an answer.

    KTS915

    (@kts915)

    Just to be clear, I am not talking about uninstalling. It would make sense to ask for my reasons then. I’d have no problem with that. I’m talking about deactivating. I don’t think it should ever ask at all when someone does that.

    Have a great weekend yourself!

    KTS915

    (@kts915)

    Just found the problem. In case you’d like to take a look for yourself, the relevant file in s2Member is /src/includes/hooks.inc.php and it appears to be using exactly the same method and priority to add its custom columns as you. If I either increase s2Member’s priority above 10 or reduce yours to below 10, then the custom columns from both plugins both show up.

    By the way, I’m not sure why you think s2Member doesn’t do things the WordPress way when years of experience with it (and nasty experiences with many other plugins) has taught me quite the opposite. I suspect you last tried it, bearing in mind WordPress’s age, rather a long time ago.

    Plugin Author Dan Cameron

    (@dancameron)

    Thanks, I’ll look into it more since my first review of the code that SI uses and s2member doesn’t immediately show me anything. For now I suggest you just change the priority of one of the plugins.

    As for my critic of s2member, I used it about 5 years ago on a major project and had to dig into the code a lot. It definitely works, it’s just overly complex and the coding standards could be better (i.e. nested conditionals, WP Standards formatting). That said I rather not debate the merits of that plugin.

    Thanks.

Viewing 4 replies - 1 through 4 (of 4 total)
  • You must be logged in to reply to this topic.