Support » Plugin: Smash Balloon Social Photo Feed » Two instances invalid html and problems with screen readers

  • Resolved carasmo

    (@carasmo)


    When I use your plugin in two different widgets, in the footer and in a sidebar, the html is invalid since the id is used twice. This makes validation for both html and accessibility fail.

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author smashballoon

    (@smashballoon)

    Hey @carasmo,

    Thanks for bringing this to our attention. The plugin does use an ID on it’s container to allow us to target it efficiently with both CSS and JavaScript, but understand that this can cause an HTML validation issue. The reason for using an ID is that initially the plugin was designed to only be used once on a page, but then it developed into allowing for multiple feeds and by that point it was too late to change it due to a lot of people using custom code snippets that rely on the ID. Having said that, we’re going to discuss a strategy for hopefully dealing with this so that we can address this issue going forward, as we agree that it isn’t ideal.

    The good news is, that despite duplicate IDs causing an HTML validation error, it won’t actually affect the performance of the plugin or your website at all. The worst case is that any accessibility tool which relies on unique IDs will simply ignore the content in the second Instagram feed and only read the content from the first one.

    We will definitely be discussing this more internally though to see what we can do to transition away from using a fixed ID on multiple feeds, whilst also affecting existing users in the most minimal way. Thanks again for bringing this up, and if you have any other questions at all then just let me know.

    John

    Thank you. Since you are finding within each instance, changing the jQuery was easy enough, the CSS using the id for everyone will be a problem. It would be a pain, but I would add an option to use a class only version. Anyway, if someone complains I’ll direct them to this thread.

    I think I’ll fork it on GitHub and use that version until…

    Thanks again!

    Plugin Author smashballoon

    (@smashballoon)

    Sounds good. I like the idea of adding an option to use the class, and perhaps defaulting to that option for all new users. Thanks for the suggestion! I have a couple of other ideas too so we’ll do some testing on our end during the next update and see what we can figure out.

    John

    HI i’m having a nightmare trying to get instragram to show up. i’m at bestfitbybrazil.com email support@bestfitbybrazil.com. I have it down now, until i hear from you. thx.

    Plugin Contributor Craig at Smash Balloon

    (@craig-at-smash-balloon)

    Hey bestfitbybrazil,

    Would you like to use our contact form to send your system info and let us know when you activate the plugin again?

    https://smashballoon.com/instagram-feed/support/

    Cool! BTW the shortcode requires the true or false atts on the load more and the show profile stuff, before it was just automatically off.

    Plugin Author smashballoon

    (@smashballoon)

    Hey @carasmo,

    In the previous update, the bio text in the header was always displayed as we didn’t have an option to disable it. In the 1.5 update that we just released a few days ago it included an option to disable the bio text. Just to clarify, are you saying that the bio text wasn’t displayed previously in your header but after updating it was?

    Also, in regards to the Load More button, the only times that it would be hidden is if it was disabled in the settings or if there weren’t enough posts in the Instagram account yet to meet the number of posts selected to be displayed in the plugin settings (eg, you have the plugin set to display 20 posts but the Instagram account only has 15). The latest update shouldn’t have affected the Load More button at all.

    You can disable both of these options in the plugin’s “Customize” settings if you’d like rather than having to use the shortcode option.

    If it seems like what occurred in your feed isn’t in line with what I described above then if you can provide some more information about the problem I can certainly look into it some more. I tried to replicate the issue you described by updating the plugin from the previous version to the latest version on my test site, but wasn’t able to replicate the problem.

    Many thanks, and I hope you’re having a great Friday!

    John

    Plugin Contributor Craig at Smash Balloon

    (@craig-at-smash-balloon)

    This thread has been quiet for awhile so I’m going to mark it as resolved. Let me know if you have more questions though!

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Two instances invalid html and problems with screen readers’ is closed to new replies.