Support » Plugin: Show your social media posts: easy & beautiful! » Twine hijacking plugin info -please fix this

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Aaron

    (@aaronfessler)

    Thank you for this report. This bug has been identified and addressed in version 2.5.4.

    (PS…The responsible developer was located, hung upside down by his toes, and fed carrots for 30 minutes.)

    I think you need to feed the developer some more carrots.

    2.5.4 did not fix the problem, so I looked at your code.

    The plugin_action_links is being called wrong. If the filter uses the basename of your plugin it should be called in the main plugin file (the one which is initially loaded) which in your case is twinesocial-widget.php.

    So remove this function from /lib/functions.php

    add_filter( 'plugin_action_links' , 'add_action_links' );
    function add_action_links ( $links ) {
            $links[] = '<a href="'. get_admin_url(null, 'admin.php?page=twinesocial-key-setting') .'">Build My Hub</a>';
            $links[] = '<a href="http://www.twinesocial.com/" target="_blank">Learn More About Twine<a>';
            return $links;
    }

    and instead put this function in twinesocial-widget.php.

    add_filter( 'plugin_action_links_' . plugin_basename( __FILE__ ), 'add_action_links' );
        function add_action_links ( $links ) {
            $links[] = '<a href="'. get_admin_url(null, 'admin.php?page=twinesocial-key-setting') .'">Build My Hub</a>';
            $links[] = '<a href="http://www.twinesocial.com/" target="_blank">Learn More About Twine<a>';
            return $links;
        }

    There are other ways of doing this but that is a simple solution.

    Also after looking at this plugin code I am very concerned about a freemium plugin that does not prefixes function names. You have functions like add_action_links … yet some functions have a prefix like twinesocial, please be consistent and prefix all your functions.

    Thanks

    Jumping on here for Aaron…

    First, thanks so much for your input. We appreciate you taking the time to point this out. If you re-download the plugin, you’ll see we’ve made your suggested changes.

    If you have any other questions feel free to contact me directly at noah at twinesocial dot com. Again, thanks so much for your help!

    All the Best,
    —Noah

    Moderator Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    @noah Beane, Are you associated with this plugin?

    Plugin Author Aaron

    (@aaronfessler)

    Hi, Andrew, Noah is a developer on the plugin.

    Moderator Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    Thank you for clarifying, I’ve updated Noah’s title.

    Thanks guys really awesome support and I think your service is great.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Twine hijacking plugin info -please fix this’ is closed to new replies.