Support » Themes and Templates » Trying to submit my theme keep getting error's.

  • Resolved LondonThemes

    (@londonthemes)


    I’m trying to submit my theme Elevated it’s a free premium WordPress theme.

    The uploader continue’s to give me error’s though.

    A lot of these error’s are for the core of the script, meaning if I edit them it may break something in my theme. I’m not sure if WordPress needs to update their uploader. I’m just trying to get my free theme submitted though. Any advice would be greatly appreciated.

    The theme is here: http://londonthemes.com/elevated-free-premium-responsive-wordpress-theme/

    /* The error’s I’m getting. */

    ◾RECOMMENDED: Text domain problems in skyali-page-builder.php. You have not included a text domain!
    ◾RECOMMENDED: Text domain problems in search.php. You have not included a text domain!
    ◾RECOMMENDED: Text domain problems in custom_post_types.php. You have not included a text domain!
    ◾RECOMMENDED: Text domain problems in archive.php. You have not included a text domain!
    ◾RECOMMENDED: No reference to add_theme_support( ‘custom-header’, $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
    ◾RECOMMENDED: No reference to add_theme_support( ‘custom-background’, $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
    ◾WARNING: thumbs.db Windows thumbnail store found.
    ◾WARNING: fwrite was found in the file save_settings.php possible file operations.
    ◾WARNING: fopen was found in the file theme_settings.php possible file operations.
    ◾WARNING: fopen was found in the file theme_options.php possible file operations.
    ◾WARNING: fopen was found in the file save_settings.php possible file operations.
    ◾WARNING: fopen was found in the file load_option_array.php possible file operations.
    ◾WARNING: fclose was found in the file theme_settings.php possible file operations.
    ◾WARNING: fclose was found in the file theme_options.php possible file operations.
    ◾WARNING: fclose was found in the file save_settings.php possible file operations.
    ◾WARNING: fclose was found in the file load_option_array.php possible file operations.
    ◾REQUIRED: class-tgm-plugin-activation.php. Themes should use add_theme_page() for adding admin pages.
    ◾RECOMMENDED: Possible variable $this found in translation function in multi-post-thumbnails.php. Translation function calls must NOT contain PHP variables.
    ◾RECOMMENDED: Possible variable $this found in translation function in class-tgm-plugin-activation.php. Translation function calls must NOT contain PHP variables.
    ◾RECOMMENDED: Possible variable $theme_text_domain found in translation function in extra_functions.php. Translation function calls must NOT contain PHP variables.
    ◾RECOMMENDED: Possible variable $sidebar_i found in translation function in functions.php. Translation function calls must NOT contain PHP variables.
    ◾RECOMMENDED: Possible variable $instance found in translation function in class-tgm-plugin-activation.php. Translation function calls must NOT contain PHP variables.
    ◾RECOMMENDED: image_resize found in the file skyali-page-builder.php. Deprecated since version 3.5. Use wp_get_image_editor() instead.
    ◾RECOMMENDED: Author URI: is missing from your style.css header.
    ◾INFO: At least one hard coded date was found in the file search.php. Consider get_option( ‘date_format’ )
    ◾INFO: At least one hard coded date was found in the file latest_news_widget.php. Consider get_option( ‘date_format’ )
    ◾INFO: At least one hard coded date was found in the file archive.php. Consider get_option( ‘date_format’ )
    ◾INFO: options.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    ◾INFO: iframe was found in the file single.php iframes are sometimes used to load unwanted adverts and code on your site.
    ◾INFO: iframe was found in the file single-portfolio.php iframes are sometimes used to load unwanted adverts and code on your site.
    ◾INFO: iframe was found in the file latest_videos_widget.php iframes are sometimes used to load unwanted adverts and code on your site.
    ◾INFO: extra_functions.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    ◾INFO: class-tgm-plugin-activation.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.

Viewing 15 replies - 1 through 15 (of 15 total)
  • A lot of these error’s are for the core of the script, meaning if I edit them it may break something in my theme.

    What core (I assume you mean a framework) are you using?

    The errors you need to address before the theme can upload without being rejected are the ones marked as Warning and/or Required. Those marked as recommended will let you upload the theme but come the review you will be asked to address some if not all of them.

    If you can fix and resolve the Warnings and Required then you should be good to go for upload.

    I’m trying to add this WordPress Theme. So I can become listed as one of the commercial website’s. The problem is my theme use’s the functions “fwrite, fopen, & fclose” I tried replacing these with the functions located here. http://codex.wordpress.org/Filesystem_API

    I keep getting the error that neither request_filesystem_credentials() function exist’s. As well as the function WP_Filesystem not existing.

    I also tried contacting the “theme-reviewers@lists.wordpress.org” it appears it’s rejecting my messages.

    Is there anything else you’d recommend for me to get this theme threw? Any help would be greatly appreciated Thank you.

    I need help on finding alternative for these functions “fwrite, fopen, & fclose” Is there anyone who’ve successfully replaced these functions?

    You may want to check out Otto’s tutorial http://ottopress.com/2011/tutorial-using-the-wp_filesystem/ — it goes into lots of detail on how to implement the API (and when not to)

    Ulrich

    (@grapplerulrich)

    WordPress Contributor

    Please provide a direct download link to the theme so anyone helping you can see the code.

    According to this page you have custom post types and shortcodes which are not allowed.
    http://make.wordpress.org/themes/guidelines/guidelines-plugin-territory/

    Amy Hendrix (I tried this method yesterday it kept giving me this error) Call to undefined function request_filesystem_credentials()

    It’s also saying the WP_Filesystem function doesn’t exist when I can see it in the file.php

    Ulrich – You can download the file here.

    Elevated – Free Premium Responsive One Page WordPress Theme

    I’m using the same script she posted above, so shouldn’t this error be showing for everyone?

    Ulrich

    (@grapplerulrich)

    WordPress Contributor

    Sorry, I do not want to register to be able to help you.

    Moderator Andrew Nevins

    (@anevins)

    Forum moderator

    These are the themes WordPress.org supports: http://wordpress.org/themes/

    [Misread]

    Ulrich

    (@grapplerulrich)

    WordPress Contributor

    @andrew LondonThemes would like to upload a theme to the theme repo and is having issues.

    You can get the one I’m working on now here.

    http://www.filedropper.com/elevated-replace-fopen-fclose_1

    This is the one giving off the error’s. The code has been placed in the scripts/admin/options.php file located at the bottom.

    I’ve also tried adding apply_filters(‘filesystem_method’, $method, $args);

    in the functions.php not sure if this helped out not I’m just trying to get this working.

    Thank to anyone who can provide help on this issue.

    Visit appearance >> elevated options

    And the error’s will appear.

    Moderator Samuel Wood (Otto)

    (@otto42)

    WordPress.org Admin

    The short of it is that your theme is probably going to need a lot of work to get into the repository, because you’re doing a lot of things that are not allowed in the official repository.

    For example, I see that you’re including tgm-plugin-activation. While Thomas’s code is very cool, it’s also a fairly massive amount of overkill. Additionally, it has features which do some things (like auto-install and activate plugins) which are not allowed for themes in the official repositories.

    Most of your file writing code seems to be centered around saving and loading settings, based on the filenames. This is generally a bad idea, for a lot of reasons.

    One is the general idea that themes should be simple and if you have to have a way to save and reload settings, then you probably have too many settings. While not everybody agrees with this in particular, it certainly is a valid point of view.

    But the specific reason for disallowing fwrite and so on is simply that it is highly unsafe to be doing file operations from a theme (or plugin) in a fashion like this when the code is meant for general release. Specifically, if you’re using this code on a shared hosting account that is not using setuid methods or has poor intra-user security, then it can be possible for a theme that “reads and writes settings” to be hacked by another user on the shared hosting account. File and process ownership is one of those things few people think about, sort of thing, and the WP_Filesystem was created to handle that for the case of WordPress and the self-updates.

    As for your particular error:

    Call to undefined function request_filesystem_credentials()

    It’s also saying the WP_Filesystem function doesn’t exist when I can see it in the file.php

    This means that you’re trying to use the filesystem functions outside of a valid “admin” context, like in the functions.php or on the front-end or something like that. This would not be a valid time to do such a thing, realistically. You shouldn’t need to be reading or writing files unless you’re on a screen in the admin specifically intended to do that. Requesting filesystem credentials has the possibility of asking the user for FTP credentials, for example. I doubt you’d want to show that to normal site visitors.

    Samuel Wood (Otto) I have it setup where no can access these file’s unless their logged in as a admin. I’m simply trying to add my free file to WordPress so I can be listed as a commercial site. This is my first free theme so I wasn’t aware of all these issue’s.

    Either way it looks like everyone is saying it’s not going to make it anyway so I’ll stop posting on this issue and only allow for download on my website. Thank you all for your time.

    Instead of focusing on how you can make the Filesystem API work in unintended ways, let’s rephrase the problem:

    What are you trying to do with this theme that requires reading and writing to files instead of using the database?

    edit: I didn’t see your last post before posting this one, and I’m sorry if it reads a little wrong as a result. Still, if you do ever want to go ahead with submitting a theme, I’d urge you to check out the Guidelines: http://codex.wordpress.org/Theme_Review. Thinking about what problem you’re really trying to solve (rather than just “how do I make XYZ work”) really is a good approach for a lot of the errors you’re running into.

    Moderator Samuel Wood (Otto)

    (@otto42)

    WordPress.org Admin

    I have it setup where no can access these file’s unless their logged in as a admin

    Yes, but that doesn’t mean the code is somehow secure. If you have code that is reading and writing files using the methods in your original post, then it’s an almost certain bet that the code is not secure, on certain types of hosting accounts (specifically, low priced ones).

    Either way it looks like everyone is saying it’s not going to make it anyway so I’ll stop posting on this issue and only allow for download on my website. Thank you all for your time.

    Of course, this is your right, but be aware that the theme review system is a process. The goal is to improve the specific quality of themes available on WordPress.org, and the general quality of themes everywhere. On submission, a reviewer should work with you to help you improve the theme and the quality of the code.

    The theme-check part of the uploader is the first step, and you can download the free Theme Check plugin to be able to run these same checks on your own site, before attempting to upload the theme.

    You should also read the Theme Review guidelines, to see what’s being checked for and potentially find some information and resources to help you out, if you change your mind.

Viewing 15 replies - 1 through 15 (of 15 total)
  • The topic ‘Trying to submit my theme keep getting error's.’ is closed to new replies.