Support » Plugin: Popup Maker - Popup for opt-ins, lead gen, & more » Trigger etc tabs not working

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Support Bel

    (@belimperial)

    Hello @runwildstudio

    Thank you for reaching out to us and we are sorry you are having this issue on your site.

    I would like to check the page where the issue is occurring. However, the link to the page is not working. Could you please re-send the page URL or if you are not comfortable sharing the page URL here, please send us a message at https://wppopupmaker.com/support/

    While for the file that you have shared with us, it did not indicate where the error is. You may hover the select2.min.js to see the full path of the file.

    Could you please check our documentation Test if a Plugin or Theme Interferes with Popup Maker to help isolate the issue.

    Thank you and we look forward to your response.

    Thread Starter runwildstudio

    (@runwildstudio)

    I just tried to send you a message and it offered me the option of Facebook or a bunch of FAQ questions that don’t answer my question.

    The URL is irrelevant as it is a backend issue. When I go to edit or create a popup, the tabs for the triggers etc are not working.
    I sent you 2 screenshots to show you the issue.

    Plugin Support Maria Togonon

    (@mariatogonon)

    Hi there @runwildstudio – we apologize for the inconvenience and thanks for sending further details.

    I would suggest you re-activate the plugin and when you are on the page with the popup settings box, see if this guide gives you anything useful to go on: Checking JavaScript Errors

    Keep us posted on how this goes. 

    Thread Starter runwildstudio

    (@runwildstudio)

    Hi,

    I’ve checked. There is only one version of jQuery installed. I had to install the Enable JQuery Migrate Helper plugin because your Popup Maker uses the version of jQuery that WordPress USED to ship. They’ve upgraded, but you haven’t. That got rid of one error. It was complaining about a function not existing until I downgraded jQuery.

    You may want to look into upgrading your plugin to work with the latest WordPress jQuery version.

    The other error I finally found to be a conflict with WP Tiles.
    I deactivated that plugin and the Trigger etc settings now work.

    Plugin Support Bel

    (@belimperial)

    Hi @runwildstudio

    Thank you for your reply.

    I believe we have addressed this issue on our previous version of Popup Maker, but I will escalate the jQuery issue to our developer.

    While for the conflict on the other plugin, we haven’t tested the third-party plugin if it is compatible with Popup Maker. Perhaps there is an error on the third-party plugin causing it to affect the trigger of the popup.

    Once we receive feedback about the jQuery issue, we will immediately update you.

    Thank you for your kind understanding on this matter.

    Plugin Author Daniel Iser

    (@danieliser)

    @runwildstudio – Bear with me, gonna give a lot of deeper detail, but I’m sorry to break it to you, our plugin was updated for the jQuery changes months before they ever were released to the public. It was a major concern of ours so we spent a lot of time testing that it worked with all 3 of the planned change sets coming in WP. We did this testing using the https://wordpress.org/plugins/wp-jquery-update-test/ plugin released by the core team that has options that change things to exactly what they would be in the upcoming 5.5-5.8 releases.

    We passed at every level.

    Now what I can say from your screenshots alone, is the issue is 100% not coming from our end, though I’m honestly confused as to how its happening in the first place, see below.

    1. Our plugin doesn’t use select2.min.js anywhere, you won’t find us enqueuing it, or loading it from our code base. We learned a long time ago (4+ years ago) that jQuery Select 2 is a finicky library, and since WooCommerce used an old version, we used a newer one and many other plugins used every version in between, there would be conflicts if we outright attempted to use it as a standalone JS script like you see on your site.

    What we did was forked it entirely, renamed it from select2 to pumselect2 with a custom prefix, and load it bundled directly into our own JS files, not an external/separate one.

    That also means we rewrote all of the CSS classes, IDs & styles to also use the pum prefix, so that we would never see a collission like that.

    https://github.com/PopupMaker/Popup-Maker/blob/master/assets/js/src/admin/general/vendor/select2.full.custom.js

    2. Because we don’t use select2 directly, we don’t even call select2 in a way that a 3rd parties version should respond too. We call a custom prefixed version called pumselect2 to initialize.

    3. In 100% of cases (for at least the past 18 months) any time we see issues on the editor pages (read our admin pages), it isn’t related to our code, but generally related to generic 3rd party JS errors occurring on our page preventing our code from running.

    In fact JS issues not being on our end has been such an issue, that the settings panel by default (if JS was disabled or erroring) renders a note that if your seeing it you should check out the following doc on info how to debug and resolve the issue as likely a JS error occurred and prevented it from rendering.

    https://docs.wppopupmaker.com/article/373-checking-javascript-errors

    First thing you need to do is what is outlined in the link just above, hover over the script the error is coming from select2.min.js and it should give you a full plugin path. That should indicate another plugin/theme at this point in time as again that file doesn’t exist in our plugins.

    Then try disabling that plugin to see if the issue resolves.

    Since you said you had to enable jQuery migrate plugin to fix issues with our plugin, I’m gonna cue you in on the fact that popups and our settings editors all rely on a working JavaScript environment.

    If you go back to when the first jQuery change occurred in WP you will find 3 long tickets where many users claimed our plugin was broken with the update.

    What you will find is that every one of them (100%) were errors thrown by the theme or another plugin, they were simply not aware of those JS errors because they didn’t see any noticeable breakages until the popups stopped working. But again broken site JS likely means no working popups, so false equivalency in this case.

    In general I’ve found that your correct, WP jQuery changes did break a lot of sites, but none from our code, all from 3rd party themes & plugins that likely don’t have the scale of our user base and don’t always review their code every time WP makes major changes.

    So my money would be on a plugin/theme that isn’t hugely popular (read doesn’t have a large user base requiring constant updates and fixes).

    If you track it down, and its a plugin I can get ahold of I’m happy to take a deeper look and try to duplicate it to try and debug and give the author more specific info as to why its throwing errors or how they might address it.

    Hope that helps.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Trigger etc tabs not working’ is closed to new replies.