Support » Plugin: Custom Login Page Customizer | LoginPress » Translation incomplete – with fix

  • Resolved Pieterjan Deneys

    (@nekojonez)


    The translation of this plugin is incomplete.
    In “class-loginpress-setup.php” on lines 196, 197 and 198 … There is no text-domain while we are working with strings.

    Currently, the file looks like this on lines 195 – 199:

            'options' => array(
                'default'  => 'Both Username Or Email Address',
                'username' => 'Only Username',
                'email'    => 'Only Email Address'
            )
    

    While it those lines should look like:

            'options' => array(
                'default'  => __('Both Username Or Email Address', 'loginpress'),
                'username' => __('Only Username', 'loginpress'),
                'email'    => __('Only Email Address', 'loginpress')
            )
    

    In addition to that, I would remove all the added languages in the language folder of the plugin since they are unneeded baggage. In addition to that, I found that the nl_NL of the plugin folder was overriding the actual nl_NL in the language folder …

    To test this fix, I had to recreate the .pot file with Loco Translate and when Loco Translate scanned, it removed several old strings and added a few new ones. I think you might want to look into that as well.

    Thx for the amazing plugin guys, I hope these things improve it just that bit more 🙂

Viewing 4 replies - 1 through 4 (of 4 total)
Viewing 4 replies - 1 through 4 (of 4 total)
  • You must be logged in to reply to this topic.