Translation does not take effect

  • Resolved cmhello

    (@cmhello)


    7 years, 6 months ago

    Thanks for your great work!

    I had a try for it and translated it into Chinese today. but I found the translation does not take effect.

    There is an error:

    The 195 line:

    load_plugin_textdomain( 'content-control' );

    Should be changed to:

    load_plugin_textdomain( 'content-control', false, dirname( plugin_basename( __FILE__ ) ) . '/languages/' );

    In addition, it is recommended to use wp_localize_script() function to make the text inside .js can be translated.

    You can get Simplified Chinese language pack from https://img.wpdaxue.com/2016/10/content-control-zh_CN.zip

    ————————–

    BTW, Could you make it be compatible with Woocommerce and Easy Digital Downloads, only buy one or more of the specified goods in order to view the content…

    Thanks again!

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Daniel Iser

    (@danieliser)

    7 years, 6 months ago

    @cmhello – The EDD & WooCommerce stuff wouldn’t be too difficult to add, but we have been looking at ways to monetize this one a bit, those sound like they would make excellent premium features.

    As for the translations, I can change that line but it would be much more beneficial to add those translations to the WordPress.org. See the guidebook on translating. This way they can be udpated by others later easily and are automatically installed on sites that have that language without the need to include dozens of language files. Google WordPress language packs for more info on how they are loaded. Since we are directing all translations to the repo like this we don’t actually need those changes in the code.

    Here is the translation index for this plugin.

    https://translate.wordpress.org/projects/wp-plugins/content-control

    Happy to have you take credit for those translations and can even submit you as a potential editor for the plugin (With my other plugin lines (Popup Maker) I give away free premium licenses for translation editors ;)).

    Thread Starter cmhello

    (@cmhello)

    7 years, 6 months ago

    Thanks for the reply!
    I have already submitted a translation to the WordPress.org.

    Plugin Author Daniel Iser

    (@danieliser)

    7 years, 6 months ago

    @cmhello – Awesome. Would you like to become the Chinese PTE? (Plugin Translation Editor). If so you will be able to approve your own translations. It also makes it easier to get strings approved quickly for other plugins as well.

    If not it may take a few weeks to find a GTE (Global Translation Editor) that will approve them. Once approved they will be available to all sites withing about 15 minutes automatically 😉

    Thread Starter cmhello

    (@cmhello)

    7 years, 6 months ago

    Sounds good! How to be a Chinese PTE?

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Translation does not take effect’ is closed to new replies.