Title is incomplete with a child theme
-
Hello
I updated the theme and wordpress both to latest versions, I updated the header.php page of my child theme even though there wasn’t any changes, but now I encounter an issue with page title, it doesn’t show the text that has been entered in theme customization.
It worked before upgrade and if I try to replace the code in header.php by a simple text, it show correctly so it’s not getting replaced or anything, just not showing the text that is entered in the administration tool.
Any idea ?
Thanks
The page I need help with: [log in to see the link]
-
Please cross check with official starter child theme available here https://themonic.com/iconic-one/
I tried but it doesn’t change anything. I’m pretty sure the issue is with my custom header.php but I copied the file from the theme itself after updating and just added a few lines, I did not change anything to <title>
<?php /* * Header Section of Iconic One * * Displays all of the <head> section and everything up till <div id="main"> * * @package WordPress - Themonic Framework * @subpackage Iconic_One * @since Iconic One 1.0 */ ?><!DOCTYPE html> <!--[if IE 7]> <html class="ie ie7" <?php language_attributes(); ?>> <![endif]--> <!--[if IE 8]> <html class="ie ie8" <?php language_attributes(); ?>> <![endif]--> <!--[if !(IE 7) | !(IE 8) ]><!--> <html <?php language_attributes(); ?>> <!--<![endif]--> <head> <meta charset="<?php bloginfo( 'charset' ); ?>" /> <meta name="viewport" content="width=device-width" /> <title><?php wp_title( '|', true, 'right' ); ?></title> <link href='https://fonts.googleapis.com/css?family=Lobster' rel='stylesheet' type='text/css'> <link rel="profile" href="http://gmpg.org/xfn/11" /> <link rel="pingback" href="<?php bloginfo( 'pingback_url' ); ?>" /> <?php // Loads HTML5 JavaScript file to add support for HTML5 elements in older IE versions. ?> <!--[if lt IE 9]> <script src="<?php echo get_template_directory_uri(); ?>/js/html5.js" type="text/javascript"></script> <![endif]--> <?php wp_head(); ?> </head> <body <?php body_class(); ?>> <div id="page" class="hfeed site"> <header id="masthead" class="site-header" role="banner"> <?php if ( get_theme_mod( 'themonic_logo' ) ) : ?> <div class="themonic-logo"> <a href="<?php echo esc_url( home_url( '/' ) ); ?>" title="<?php echo esc_attr( get_bloginfo( 'name', 'display' ) ); ?>" rel="home"><img src="<?php echo esc_url( get_theme_mod( 'themonic_logo' ) ); ?>" alt="<?php echo esc_attr( get_bloginfo( 'name', 'display' ) ); ?>"></a> </div> <div class="gvme_slogan-container"> <div class="gvme_slogan">" Faire du ciel le plus bel endroit de la terre "</div> </div> <?php if( get_theme_mod( 'iconic_one_social_activate' ) == '1') { ?> <div class="socialmedia"> <?php if( get_theme_mod( 'twitter_url' ) !== '' ) { ?> <a href="<?php echo esc_url( get_theme_mod( 'twitter_url', 'default_value' ) ); ?>" target="_blank"><img src="<?php echo get_template_directory_uri(); ?>/img/twitter.png" alt="Follow us on Twitter"/></a> <?php } ?> <?php if( get_theme_mod( 'facebook_url' ) !== '' ) { ?> <a href="<?php echo esc_url( get_theme_mod( 'facebook_url', 'default_value' ) ); ?>" target="_blank"><img src="<?php echo get_template_directory_uri(); ?>/img/facebook.png" alt="Follow us on Facebook"/></a> <?php } ?> <?php if( get_theme_mod( 'plus_url' ) !== '' ) { ?> <a href="<?php echo esc_url(get_theme_mod( 'plus_url', 'default_value' ) ); ?>" rel="author" target="_blank"><img src="<?php echo get_template_directory_uri(); ?>/img/gplus.png" alt="Follow us on Google Plus"/></a> <?php } ?> <?php if( get_theme_mod( 'rss_url' ) !== '' ) { ?> <a class="rss" href="<?php echo esc_url( get_theme_mod( 'rss_url', 'default_value' ) ); ?>" target="_blank"><img src="<?php echo get_template_directory_uri(); ?>/img/rss.png" alt="Follow us on rss"/></a> <?php } ?> </div> <?php } ?> <?php else : ?> <hgroup> <a href="<?php echo esc_url( home_url( '/' ) ); ?>" title="<?php echo esc_attr( get_bloginfo( 'name', 'display' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a> <br .../> <a class="site-description"><?php bloginfo( 'description' ); ?></a> </hgroup> <?php if( get_theme_mod( 'iconic_one_social_activate' ) == '1') { ?> <div class="socialmedia"> <?php if( get_theme_mod( 'twitter_url' ) !== '' ) { ?> <a href="<?php echo esc_url( get_theme_mod( 'twitter_url', 'default_value' ) ); ?>" target="_blank"><img src="<?php echo get_template_directory_uri(); ?>/img/twitter.png" alt="Follow us on Twitter"/></a> <?php } ?> <?php if( get_theme_mod( 'facebook_url' ) !== '' ) { ?> <a href="<?php echo esc_url( get_theme_mod( 'facebook_url', 'default_value' ) ); ?>" target="_blank"><img src="<?php echo get_template_directory_uri(); ?>/img/facebook.png" alt="Follow us on Facebook"/></a> <?php } ?> <?php if( get_theme_mod( 'plus_url' ) !== '' ) { ?> <a href="<?php echo esc_url(get_theme_mod( 'plus_url', 'default_value' ) ); ?>" rel="author" target="_blank"><img src="<?php echo get_template_directory_uri(); ?>/img/gplus.png" alt="Follow us on Google Plus"/></a> <?php } ?> <?php if( get_theme_mod( 'rss_url' ) !== '' ) { ?> <a class="rss" href="<?php echo esc_url( get_theme_mod( 'rss_url', 'default_value' ) ); ?>" target="_blank"><img src="<?php echo get_template_directory_uri(); ?>/img/rss.png" alt="Follow us on rss"/></a> <?php } ?> </div> <?php } ?> <?php endif; ?> <nav id="site-navigation" class="themonic-nav" role="navigation"> <a class="assistive-text" href="#content" title="<?php esc_attr_e( 'Skip to content', 'themonic' ); ?>"><?php _e( 'Skip to content', 'themonic' ); ?></a> <?php wp_nav_menu( array( 'theme_location' => 'primary', 'menu_id' => 'menu-top', 'menu_class' => 'nav-menu' ) ); ?> </nav><!-- #site-navigation --> <div class="clear"></div> </header><!-- #masthead --> <div id="main" class="wrapper">
Please note that
<title><?php wp_title( '|', true, 'right' ); ?></title>
is not needed as titles are now handled by WordPress.
Also, if you are modifying the header.php just to add fonts then there is a better way: enqueue fonts in the functions.php of official child theme like below:
function iconic_one_load_google_font() { wp_enqueue_style( 'google-fonts', '//fonts.googleapis.com/css?family=Lobster:300,700'); } add_action( 'wp_enqueue_scripts', 'iconic_one_load_google_font' );
- This reply was modified 4 years, 3 months ago by Themonic.
Very good thanks, removing title fixed it 🙂
I also changed as you suggested. Thanks for your help and happy new year !I am glad it worked for you. HNY to you too.
If possible do leave us rating/review https://wordpress.org/support/theme/iconic-one/reviews/
- This reply was modified 4 years, 3 months ago by Jan Dembowski. Reason: Deleted ?filter=5 from link, don't do that
@themonic Don’t put
?filter=5
in your review links, it hides the non-5 star reviews from the person who uses that link and that’s not being completely honest. That’s not necessary as the stars default to 5 for all new reviews. The reviewer would manually need to change it to something other than 5 if they wanted to.I’ve removed that part and now they’ll see the actual reviews and not just the 5 star ones.
@jdembowski Thank you for the edit.
I have a question for you:
What to do with the mods deleting the reviews out of the blue? if a user shared their website link in review, most just want show their new site, the link should be removed and not the review right?
Reviews are only removed for cause. If you need to contact the moderators about this then you can do so via the Slack #forums channel.
To use that channel you need a Slack account. You can obtain one via these instructions.
https://make.wordpress.org/chat/
If you do use Slack do not direct message me or any other moderator. Use the #forums channel and any moderator there can assist you.
- The topic ‘Title is incomplete with a child theme’ is closed to new replies.