Support » Theme: Tiny Framework » tinyframework_semantics_{$id} hook firing for each type of element

  • Resolved mclaurent

    (@mclaurent)


    Heya

    I stumbled across this line in the semantics.php file which allows developers to customise the semantic values for each HTML element. It looks like the ID-specific filter fires actions for each element rather than just the current element (sorry it is a bit difficult to explain). I believe the filter name should be wrapped in double-quotes instead of single-quotes so that the {$id} portion of the filter hook is parsed by PHP. Currently the {$id} is never replaced by its value because it is wrapped in single quotes.

    Line: wp-content/themes/tiny-framework/inc/semantics.php:544

    I think the line should be changed

    FROM

    
    	$classes = apply_filters( 'tinyframework_semantics_{$id}', $classes, $id );
    

    TO

    
    	$classes = apply_filters( "tinyframework_semantics_{$id}", $classes, $id );
    

    Thanks

Viewing 4 replies - 1 through 4 (of 4 total)
Viewing 4 replies - 1 through 4 (of 4 total)
  • You must be logged in to reply to this topic.