Thumbnails now break popup mechanisms

  • OnePressTech

    (@timhibberd)


    8 years, 4 months ago

    Hi Guys,

    Love your plug-in but your recent update from v1.1.7 to v1.2.x broke my popup code (see below) which was a workaround for your v1.x not working in off-the-shelf popup plugins (see previous reported bug).

    It looks like your thumbnails now link directly to their associated pages whereas they were previously linked via a JavaScript assisted list. This switch from relative to absolute page targeting seems to have mucked up my popup code (see below).

    Any ideas?

    Thanks in advance…much appreciated.

    Oh, also, in v1.2.x there is now a little white blank page tab on the top right of the flipbook page…is that supposed to be blank?

    ————————————
    See next post for popup code sample
    ————————————-

Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter OnePressTech

    (@timhibberd)

    8 years, 4 months ago

    Sorry…that code should have read:

    ————————————————-

    <p style="text-align: center;">
<a href="#" onclick="toggle_visibility('opt_flipbook_popup250')">
Read the Cervical Fascia Chapter
</a>
</p>

<div id="opt_flipbook_popup250" style="display: block; visibility: hidden; background: #EBE0FF; left: 0px; right: 0px; top: 0px; bottom: 0px; z-index: 100000; position: fixed; overflow: scroll; opacity: 1.0;">

<a href="#" onclick="toggle_visibility('opt_flipbook_popup250')">
<span style="color: white; position:fixed; left: 10px; top:10px; background-color:black; font-weight:bold;z-index:20000">&nbsp;X&nbsp;</span>
</a>

[pdf-light-viewer id="250"]

</div>

<script type="text/javascript">
<!--

function toggle_visibility(id) {
var e = document.getElementById(id);
if(e.style.visibility == 'hidden')
e.style.visibility = 'visible';
else
e.style.visibility = 'hidden';
}
//-->
</script>'

    ————————————————-

    Plugin Author antongorodezkiy

    (@antongorodezkiy)

    8 years, 3 months ago

    Hello @onepresstech,

    Is there a chance to check the issue on the online example? Links of the thumbnails should not be clickable anyways. There is onclick event which should avoid that. Maybe in your case you just need to re-attach the onlick event?

    > Oh, also, in v1.2.x there is now a little white blank page tab on the top right of the flipbook page…is that supposed to be blank?

    I understood what you mean, thank you, this is an issue. Will be fixed in the next release.

    Thread Starter OnePressTech

    (@timhibberd)

    8 years, 3 months ago

    Thank you for following up on this issue.

    I’m puzzled as to why you are saying the thumbnails should not be clickable. They were clickable in the releases up to 1.2.x and it makes sense in a large document to be able to use the thumbnails to jump immediately to a specific page.

    In particular there is an outstanding bug previously reported that the page turning mechanism is non-functional on a Chrome browser. On the Chrome browser the only way to go to a page is via clickable thumbnails.

    I was just wondering what changed from pre-v1.2.x to v1.2.x w.r.t. clickable thumbnails?

    Thanks in advance…much appreciated.

    Plugin Author antongorodezkiy

    (@antongorodezkiy)

    8 years, 3 months ago

    Maybe I’ve incorrectly expressed my idea.

    > It looks like your thumbnails now link directly to their associated pages whereas they were previously linked via a JavaScript assisted list. This switch from relative to absolute page targeting seems to have mucked up my popup code (see below).

    I just mean that urls of the links should not be an issue for the popup. Because default links behavior is overridden by javascript with preventDefault().

    Is there a chance to test this example on your site? Just let me know. If this is some kind of secret you could send link to the support@teamlead.pw if possible

    Plugin Author antongorodezkiy

    (@antongorodezkiy)

    8 years, 3 months ago

    > I was just wondering what changed from pre-v1.2.x to v1.2.x w.r.t. clickable thumbnails?

    Here you can find a commit diff https://github.com/antongorodezkiy/pdf-light-viewer/commit/b0955e0b2018e0bd0632ad27996f3453f31fe628 ( assets/js/magazine.js contains javascript logic )

    But I still couldn’t understand what exactly not working.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Thumbnails now break popup mechanisms’ is closed to new replies.