Support » Plugin: Transposh WordPress Translation » This function does some ad replacement for transposh benefit

  • Resolved bycomplex

    (@bycomplex)


    Hello,
    What’s this code for? What does it do?

    In transposh-translation-filter-for-wordpress/core/parser.php
    line 657 – 678

    
        /**
         * This function does some ad replacement for transposh benefit
         */
        function do_ad_switch() {
            if (isset($this->html->noise) && is_array($this->html->noise)) {
                foreach ($this->html->noise as $key => $value) {
                    if (strpos($value, 'google_ad_client') !== false) {
                        $publoc = strpos($value, 'pub-');
                        $sufloc = strpos($value, '"', $publoc);
                        if (!$sufloc)
                            $sufloc = strpos($value, "'", $publoc);
                        echo $publoc . ' ' . $sufloc;
                        if ($publoc && $sufloc)
                            $this->html->noise[$key] = substr($value, 0, $publoc) . 'pub-752..........76' . substr($value, $sufloc);
                    }
                }
            }
            // INS TAGS
            foreach ($this->html->find('ins') as $e) {
                $e->{'data-ad-client'} = 'ca-pub-752........76';
            }
        }
    
    • This topic was modified 7 months, 3 weeks ago by  Jan Dembowski.
Viewing 15 replies - 1 through 15 (of 16 total)
  • I contacted the owner with mail. I told him you had no right. Unfortunately, he thinks he’s right.

    Anyways.

    I’ve changed the following codes in parser.php as follows;

    In “transposh-translation-filter-for-wordpress/transposh.php” ;
    Lines ~ 3 to 13
    (For this plugin to be NOT update in the future…)

    /*
      Plugin Name: Transposh Translation Filter
      Plugin URI: http://transposh.org/
      Description: ................
      Author: Team Transposh
      Version: 1.0.4.1
      Author URI: http://transposh.org/
      License: GPL (http://www.gnu.org/licenses/gpl.txt)
      Text Domain: transposh
      Domain Path: /langs
     */

    TO

    /*
      Plugin Name: Transposh Translation Filter
      Plugin URI: http://transposh.org/
      Description: ................
      Author: Team Transposh
      Version: 100.0.4.1
      Author URI: http://transposh.org/
      License: GPL (http://www.gnu.org/licenses/gpl.txt)
      Text Domain: transposh
      Domain Path: /langs
     */

    AND in “transposh-translation-filter-for-wordpress/core/parser.php” ;
    Lines ~ 657 to 678

        /**
         * This function does some ad replacement for transposh benefit
         */
        function do_ad_switch() {
           if (isset($this->html->noise) && is_array($this->html->noise)) {
                foreach ($this->html->noise as $key => $value) {
                    if (strpos($value, 'google_ad_client') !== false) {
                        $publoc = strpos($value, 'pub-');
                        $sufloc = strpos($value, '"', $publoc);
                        if (!$sufloc)
                            $sufloc = strpos($value, "'", $publoc);
                        echo $publoc . ' ' . $sufloc;
                        if ($publoc && $sufloc)
                            $this->html->noise[$key] = substr($value, 0, $publoc) . 'pub-752............676' . substr($value, $sufloc);
    
                    }
                }
            }
            // INS TAGS
            foreach ($this->html->find('ins') as $e) {
                $e->{'data-ad-client'} = 'ca-pub-752.................76';
            }
        }

    TO

        /**
         * This function does some ad replacement for transposh benefit
         */
        function do_ad_switch() {
     /*************       if (isset($this->html->noise) && is_array($this->html->noise)) {
    
                foreach ($this->html->noise as $key => $value) {
                    if (strpos($value, 'google_ad_client') !== false) {
                        $publoc = strpos($value, 'pub-');
                        $sufloc = strpos($value, '"', $publoc);
                        if (!$sufloc)
                            $sufloc = strpos($value, "'", $publoc);
                        echo $publoc . ' ' . $sufloc;
                        if ($publoc && $sufloc)
                            $this->html->noise[$key] = substr($value, 0, $publoc) . 'pub-75.........76' . substr($value, $sufloc);
    
                    }
                }
            }
            // INS TAGS
            foreach ($this->html->find('ins') as $e) {
                $e->{'data-ad-client'} = 'ca-pub-75.............76';
            }
      ***********/  } 

    AND
    Lines ~ 1014 to 1020

                // we might show an ad for transposh in some cases
                if (($this->allow_ad && !$this->default_lang && mt_rand(1, 100) > 95) || // 5 of 100 for translated non default language pages
                        ($this->allow_ad && $this->default_lang && mt_rand(1, 100) > 99) || // 1 of 100 for translated default languages pages
                        (!$this->allow_ad && mt_rand(1, 1000) > 999)) { // 1 of 1000 otherwise
                    $this->do_ad_switch();
                }

    TO

                // we might show an ad for transposh in some cases
         /************       if (($this->allow_ad && !$this->default_lang && mt_rand(1, 100) > 95) || // 5 of 100 for translated non default language pages
                        ($this->allow_ad && $this->default_lang && mt_rand(1, 100) > 99) || // 1 of 100 for translated default languages pages
                        (!$this->allow_ad && mt_rand(1, 1000) > 999)) { // 1 of 1000 otherwise
                    $this->do_ad_switch();
                }
    			**************/ 

    I think these changes end this robbery for about 10 years.

    Thank you

    • This reply was modified 7 months, 3 weeks ago by  bycomplex. Reason: remove tags
    Plugin Author Ofer Wald

    (@oferwald)

    Hello Moderator,

    Would appreciate removal of this post blaming me of robbery.

    The code presented here does not exist on the wordpress.org version of the plugin. and is taken out of context, and anyhow – there are ways to criticize other people, which the author clearly ignored.
    ——-
    ps. see the tagging here – Transposh theft etc. really?

    I dont see any robery since the plugin is free ………..

    Then you will say; You must have to say clearly;
    The plugin you downloaded here is “useless.”

    Come on, download my version of “adsense revenue” from my site.
    This version on the wordpress.org: “No useless without widgets ect.”

    If you want to use the widget, come to my site, download it, let me change your adsense codes.

    What happens if every plugin does what you do?

    Dear moderator;
    Instead of removing this topic, you should remove this plugin from the site.
    After downloading and installing from WordPress.org,
    On the management page asks;
    For Widget etc. , do I install my site version?
    It is useless without widget etc.
    All right, we’re gonna say okay.
    And then it starts to change the adsense codes on our sites.

    Please think; What happens if every plugin does it?

    I’m the one who has “modlook”ed this topic.

    I talked to the author by mail.
    He thinks he’s right.
    For almost 10 years, without many of us knowing,
    With a code in the background
    He took himself our “Adsense” earnings.
    %1 , %5 , %15 it doesn’t matter what.
    This should not be allowed.

    Thank you

    So your code removes the adsense changer ?!

    Someone who has not responded to any support question for almost 1-2 year
    now come and answer all the questions …
    πŸ™‚

    “So your code removes the adsense changer ?!”
    This is not my code. I can only add /** */ codes. I don’t know if it works.

    I mean,
    The version in WordPress.org does not have these codes.
    Which means,
    This plugin in Transposh.org
    “more convenient to use”
    version contains these codes.

    If you selected “allow updates” in your administration panel,
    ADSENSE CODES ARE CHANGING!

    I’m not sure if the changes I’ve made to the code finish this …

    Anyway. I’m not gonna use that anymore…

    @pipetko

    This is exactly what I want to say….
    “”””
    https://wordpress.org/support/topic/how-to-upgrade-for-more-than-5-languages/#post-11149567
    “”””

    I understand, thanks πŸ™‚ I am using it anyway on nonadsensed websites, jut on my clients websites for multilangual purpouse.

    I personally prefer if he makes it payd for 10-20 bucks or make a donation button for the plugin, because otherways its usefull and only one plugin that has those optios for translation. And its working perfectly regarding the options that it presents.

    Moderator Jan Dembowski

    (@jdembowski)

    Forum Moderator and Brute Squad

    *Looks, removes modlook tag*

    The version that’s in the WordPress repo doesn’t have that code.

    *Installs plugin. Sees “Upgrade to full version” in plugin settings.*

    Huh. What does that do?

    https://cloudup.com/cYgCzv6tPqn

    *Clicks button*

    Didn’t seem to do anything yet.

    *Manually gets full download from site*

    OH. THAT’S NOT GOOD. How long has that been going on?

    @oferwald You may get an email from plugins.

    Here’s the problem. You are enticing your users in your plugin settings to “Allow upgrading to full version from http://transposh.org, which has no limit on languages used and includes a full set of widgets” in their dashboard. More languages and widgets? Cool.

    You are hiding the fact that “upgraded” users may be giving you ad revenue either as an option or not.

    I have not done a deep dive into the new code but see line 657 in the copy I retrieved from your site. It’s the comment that says “This function does some ad replacement for transposh benefit”.

    https://pastebin.com/bKs04MeV

    I assume it has something to do with this? Or not?

    https://cloudup.com/cLh2sHq105Z

    Either way, it’s not quite aboveboard and I am reporting this to plugins.

    Yes, you are technically not doing that on WordPress.org but you are not being aboveboard either about the ad revenue. What you do with the code on your site isn’t the business of anyone here (I think) but downloading that code under the pretense of getting more widgets isn’t really full disclosure.

    @jdembowski

    Thank you for your interest.
    Will you please look over here?

    https://wordpress.org/support/topic/this-function-does-some-ad-replacement-for-transposh-benefit-2/

    Thank you

    Moderator Jan Dembowski

    (@jdembowski)

    Forum Moderator and Brute Squad

    Yeah, I closed that one with a link. Same topic but this is the place that this belongs.

    OK, thank you.
    And,

    “”OH. THAT’S NOT GOOD. How long has that been going on?””

    I think about 10 years!!!
    So ugly..

    Plugin Author Ofer Wald

    (@oferwald)

    @bycomplex your messages are ugly, and I will quote:

    I am 38 years old.
    Until this age, I didn’t break anybody willingly.
    I’m so sorry to break you.

    You have no right to do this and you are not competent.

    Anyhow – @jdembowski , I have sent you an email, I am really sorry that you decided to leave the stage like this.

    I do hope you will change your moderation decision, or at the least remove the offensive tags from the other message

    Moderator Jan Dembowski

    (@jdembowski)

    Forum Moderator and Brute Squad

    I didn’t “leave the stage”. My original reply was 48 minutes ago. And I did get your email I’ll reply later.

    The tags are gone and someone from plugins may chime in. Or not; this topic may get closed by someone else.

    @bycomplex Take a break please, OK? There’s no violation of the plugin guidelines exactly here. I have sent the plugins team my concerns but there’s nothing here that’s a blatant violation.

    This isn’t a fight, it’s a conversation. I happen to know for a fact that Ofer is quite reasonable. Please do not mistake my writing style or humor for anything angry or mean. That’s not the case and I know Ofer does not have any ill intent.

Viewing 15 replies - 1 through 15 (of 16 total)
  • The topic ‘This function does some ad replacement for transposh benefit’ is closed to new replies.