"There was no automatic update" check is a bit excessive

Resolved

(@jgraup)

I’m seeing a lot of checks for updates in my DEBUG log. Do you think you could throttle this a little bit more like, once a day? I doubt changing my favicon requires real-time up-to-the-second code — especially since this plugin is already doing a great job.

Thanks

[11-Aug-2015 15:48:57 America/New_York] RFG - Check if manual update notice should be displayed
[11-Aug-2015 15:48:57 America/New_York] RFG - There is no pending manual update
[11-Aug-2015 15:48:57 America/New_York] RFG - Check if automatic update notice should be displayed
[11-Aug-2015 15:48:57 America/New_York] RFG - There was no automatic update
[11-Aug-2015 15:49:03 America/New_York] RFG - Check if manual update notice should be displayed
[11-Aug-2015 15:49:03 America/New_York] RFG - There is no pending manual update
[11-Aug-2015 15:49:03 America/New_York] RFG - Check if automatic update notice should be displayed
[11-Aug-2015 15:49:03 America/New_York] RFG - There was no automatic update
[11-Aug-2015 15:49:09 America/New_York] RFG - Check if manual update notice should be displayed
[11-Aug-2015 15:49:09 America/New_York] RFG - There is no pending manual update
[11-Aug-2015 15:49:09 America/New_York] RFG - Check if automatic update notice should be displayed
[11-Aug-2015 15:49:09 America/New_York] RFG - There was no automatic update
[11-Aug-2015 15:49:17 America/New_York] RFG - Check if manual update notice should be displayed
[11-Aug-2015 15:49:17 America/New_York] RFG - There is no pending manual update
[11-Aug-2015 15:49:17 America/New_York] RFG - Check if automatic update notice should be displayed
[11-Aug-2015 15:49:17 America/New_York] RFG - There was no automatic update
[11-Aug-2015 15:49:53 America/New_York] RFG - Check if manual update notice should be displayed
[11-Aug-2015 15:49:53 America/New_York] RFG - There is no pending manual update
[11-Aug-2015 15:49:53 America/New_York] RFG - Check if automatic update notice should be displayed
[11-Aug-2015 15:49:53 America/New_York] RFG - There was no automatic update
[11-Aug-2015 15:50:05 America/New_York] RFG - Check if manual update notice should be displayed
[11-Aug-2015 15:50:05 America/New_York] RFG - There is no pending manual update
[11-Aug-2015 15:50:05 America/New_York] RFG - Check if automatic update notice should be displayed
[11-Aug-2015 15:50:05 America/New_York] RFG - There was no automatic update
[11-Aug-2015 15:52:11 America/New_York] RFG - Check if manual update notice should be displayed
[11-Aug-2015 15:52:11 America/New_York] RFG - There is no pending manual update
[11-Aug-2015 15:52:11 America/New_York] RFG - Check if automatic update notice should be displayed
[11-Aug-2015 15:52:11 America/New_York] RFG - There was no automatic update
[11-Aug-2015 15:52:17 America/New_York] RFG - Check if manual update notice should be displayed
[11-Aug-2015 15:52:17 America/New_York] RFG - There is no pending manual update
[11-Aug-2015 15:52:17 America/New_York] RFG - Check if automatic update notice should be displayed
[11-Aug-2015 15:52:17 America/New_York] RFG - There was no automatic update
[11-Aug-2015 15:55:11 America/New_York] RFG - Check if manual update notice should be displayed
[11-Aug-2015 15:55:11 America/New_York] RFG - There is no pending manual update
[11-Aug-2015 15:55:11 America/New_York] RFG - Check if automatic update notice should be displayed
[11-Aug-2015 15:55:11 America/New_York] RFG - There was no automatic update

https://wordpress.org/plugins/favicon-by-realfavicongenerator/

Viewing 14 replies - 1 through 14 (of 14 total)

Plugin Author phbernard
(@phbernard)

8 years, 8 months ago

Sorry for the late answer. I’m on vacation. Damn free time! 🙂

This must be because you have WP_DEBUG enable somewhere in your WP config. The plugin normally doesn’t log so many things.

FYI, this code is triggered only in the admin section. The public section is very light, on purpose, and doesn’t log anything (whatever the debug settings). This is to be as fast as possible.

Plugin Author phbernard
(@phbernard)

8 years, 8 months ago

I didn’t mark the topic as resolved when I first answer it, but I guess this closes the point.

Don’t hesitate to re-open it if you think there is something wrong.
Thread Starter Jesse Graupmann
(@jgraup)

8 years, 8 months ago
All good. Yes, I’m developing a theme locally and I am doing a lot of logging to iterate on my own features so WP_DEBUG is true.

I guess this is two-fold.

1) I only care when a plugin needs to be updated and even then I like to wait a bit before upgrading.

2) I want my logs as clean as possible.

Does setting ‘fbrfg_dismiss_all_update_notifications’ remove this output? Or could you add another option in log_info;
```
// /plugins/favicon-by-realfavicongenerator/public/class-favicon-by-realfavicongenerator-common.php
public function log_info( $message ) {
   if ( ( constant( 'WP_DEBUG') == 'true' ) || ( constant( 'WP_DEBUG') == 1 ) ) {
      if ( constant( ‘RFG_DEBUG') == 'true’ ) {
            error_log( 'RFG - ' . $message );
      }
   }
}
```
Keep in mind this is pretty minor in the grand scheme of things.

Either way, I appreciate your consideration.
Plugin Author phbernard
(@phbernard)

8 years, 7 months ago

Okay, I understand.

I’ll do it the opposite way: you will have the opportunity to explicitly disable RFG’s debug logs, by setting RFG_DEBUG to false. But by default, you will get all RFG’s output. After all, this is the purpose of WP_DEBUG.
awtx
(@awtx)

8 years, 5 months ago
@phbernard, you are missing the point.
Don’t force the plugin to hide errors, that is a tremendous mistake.
Hiding the error output doesn’t fix the problem. Your plugin should not be generating errors if it is functioning properly. Can you imagine what would happen to a busy site if all the plugins behaved like yours?

Let WordPress handle the daily update check. You should not be generating extra traffic or using additional resources. If your plugin is generating debug entries, then you have some coding to clean up.

We like the plugin, we are simply asking you to make it more resource friendly.
```
[19-Nov-2015 15:40:58 UTC] RFG - Check if manual update notice should be displayed
[19-Nov-2015 15:40:58 UTC] RFG - There is no pending manual update
[19-Nov-2015 15:40:58 UTC] RFG - Check if automatic update notice should be displayed
[19-Nov-2015 15:40:58 UTC] RFG - There was no automatic update
```
Hrohh
(@hrohh)

8 years, 5 months ago

+ thx

Plugin Author phbernard
(@phbernard)

8 years, 5 months ago

Hi,

These messages are not related to checking remotely if an update is available. Instead, they are only debug messages to trace the code that displays (or not) the update notice in the dashboard. They simply reflect a few if.

The presence of such messages in your logs doesn’t mean an HTTP access was made to RFG. The “real”, time-consuming and resource-consuming checking is done through wp_schedule_event, once per day.

Does that answer your question of do I miss something?

Clifford Paulick
(@cliffpaulick)

8 years, 2 months ago

I’m seeing these too:

[17-Feb-2016 07:25:00 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:25:00 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:25:00 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:25:00 UTC] RFG – There was no automatic update
[17-Feb-2016 07:25:36 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:25:36 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:25:36 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:25:36 UTC] RFG – There was no automatic update
[17-Feb-2016 07:26:21 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:26:21 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:26:21 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:26:21 UTC] RFG – There was no automatic update
[17-Feb-2016 07:26:33 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:26:33 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:26:33 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:26:33 UTC] RFG – There was no automatic update
[17-Feb-2016 07:26:42 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:26:42 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:26:42 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:26:42 UTC] RFG – There was no automatic update
[17-Feb-2016 07:26:54 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:26:54 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:26:54 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:26:54 UTC] RFG – There was no automatic update
[17-Feb-2016 07:27:08 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:27:08 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:27:08 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:27:08 UTC] RFG – There was no automatic update
[17-Feb-2016 07:27:29 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:27:29 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:27:29 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:27:29 UTC] RFG – There was no automatic update
[17-Feb-2016 07:27:57 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:27:57 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:27:57 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:27:57 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:03 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:03 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:03 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:03 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:07 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:07 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:07 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:07 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:09 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:09 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:09 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:09 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:11 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:11 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:11 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:11 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:22 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:22 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:22 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:22 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:33 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:33 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:33 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:33 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:35 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:35 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:35 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:35 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:35 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:35 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:35 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:35 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:36 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:36 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:36 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:36 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:36 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:36 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:36 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:36 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:37 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:37 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:37 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:37 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:38 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:38 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:38 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:38 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:38 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:38 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:38 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:38 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:39 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:39 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:39 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:39 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:40 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:40 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:40 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:40 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:40 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:40 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:40 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:40 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:41 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:41 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:41 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:41 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:42 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:42 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:42 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:42 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:43 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:43 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:43 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:43 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:43 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:43 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:43 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:43 UTC] RFG – There was no automatic update
[17-Feb-2016 07:28:53 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:28:53 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:28:53 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:28:53 UTC] RFG – There was no automatic update
[17-Feb-2016 07:29:55 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:29:55 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:29:55 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:29:55 UTC] RFG – There was no automatic update
[17-Feb-2016 07:30:11 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:30:11 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:30:11 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:30:11 UTC] RFG – There was no automatic update
[17-Feb-2016 07:30:23 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:30:23 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:30:23 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:30:23 UTC] RFG – There was no automatic update
[17-Feb-2016 07:30:32 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:30:32 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:30:32 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:30:32 UTC] RFG – There was no automatic update
[17-Feb-2016 07:30:49 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:30:49 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:30:49 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:30:49 UTC] RFG – There was no automatic update
[17-Feb-2016 07:30:54 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:30:54 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:30:54 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:30:54 UTC] RFG – There was no automatic update
[17-Feb-2016 07:31:12 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:31:12 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:31:12 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:31:12 UTC] RFG – There was no automatic update
[17-Feb-2016 07:31:53 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:31:53 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:31:53 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:31:53 UTC] RFG – There was no automatic update
[17-Feb-2016 07:32:41 UTC] RFG – Check if manual update notice should be displayed
[17-Feb-2016 07:32:41 UTC] RFG – There is no pending manual update
[17-Feb-2016 07:32:41 UTC] RFG – Check if automatic update notice should be displayed
[17-Feb-2016 07:32:41 UTC] RFG – There was no automatic update

Plugin Author phbernard
(@phbernard)

8 years, 2 months ago

Theses are debug strings, printed in the logs because your WP_DEBUG WordPress setting must be enabled (probably in your wp-config.php). These messages will be gone as soon as you disable debugging messaging with WP_DEBUG.

And again, these lines are not related with the automatic favicon update checking. The checking happens once per day and is triggered by WordPress regular wp_schedule_event, as it should. Instead, these lines are part of the code that decides if a notice should be displayed in the dashboard or not. There is no heavy processing behind them (like an HTTP access…), only a mundane less-than-a-millisecond processing.

Does this help?

Clifford Paulick
(@cliffpaulick)

8 years, 2 months ago

Yes, I have WP_DEBUG on.

First, I’d recommend/request making “RFG” more descriptive. It took me some effort to investigate which plugin was generating these messages.

As far as keeping a log of whatever checks the plugin’s doing or logging — for whatever reason — it sure is overtaking my /wp-content/debug.log, which I’d ideally like to keep as clean as possible for debug-related messages.

Your plugin is awesome except for cluttering my debug.log. I’d suggest making it an option to turn off these messages or, better yet, make them off and make it an option to enable such logging.

tyvm for receiving this feedback and for your plugin! 🙂

Plugin Author phbernard
(@phbernard)

8 years, 1 month ago

Hum… I understand. Actually, these debug strings are not that useful unless you want to debug the plugin, which shouldn’t happen that often 🙂

I’m going to add an additional switch to turn these entries off by default, so only people interested in RFG plugin debugging will see them.

I would like to handle this issue and the WPML one at the same time. So as soon as I get material to fix the WPML issue, I’ll publish a new version.

Thank you for your feedback!

Clifford Paulick
(@cliffpaulick)

8 years, 1 month ago

tyvm for your understanding! 🙂

Plugin Author phbernard
(@phbernard)

8 years, 1 month ago

Done! Version 1.3.3 (submitted a minute ago) doesn’t log debug messages unless you explicitly ask for it with the RFG_DEBUG config.

Clifford Paulick
(@cliffpaulick)

8 years, 1 month ago

Awesome! Thanks.

Viewing 14 replies - 1 through 14 (of 14 total)

The topic ‘"There was no automatic update" check is a bit excessive’ is closed to new replies.

Tags