textdomain.php

  • Resolved didax

    (@didax)


    8 years, 6 months ago

    Hi,

    first of all… thank you for this incredible plugin.

    In my opinion there is an error at /checks/textdomain.php.
    When user has a theme without any of the rules declared inside TextDomainCheck class, an error occur (you can test it to reproduce warnings).
    It can be solved declaring $domains before the check and altering $domainscount considering 0, 1 and more than 1 occurrences.

    See you…

    https://wordpress.org/plugins/theme-check/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Samuel Wood (Otto)

    (@otto42)

    WordPress.org Admin

    8 years, 6 months ago

    Could you provide an example that would cause this issue, for testing?

    Thread Starter didax

    (@didax)

    8 years, 6 months ago

    Hi,

    it’s quite simple. You must have a theme where no __, _c, … commands are launched.
    At this point using WP_DEBUG you can see the warnings.

    Plugin Author Samuel Wood (Otto)

    (@otto42)

    WordPress.org Admin

    8 years, 6 months ago

    How can you have a theme that does not output anything?

    Doing translation calls is really not optional. The most likely “fix” for this is simply to fail the theme if it lacks any translation calls.

    Thread Starter didax

    (@didax)

    8 years, 6 months ago

    Obviously the theme it is not correct if it does not use translation calls.

    The point is not that!

    I said that the plugin should output a message to let user know that lack.
    Instead the plugin show internal warnings and output a bad message…

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘textdomain.php’ is closed to new replies.