span tags on everything breaking layouts

  • Jesse Pearson (a11n)

    (@jessepearson)


    Automattic Happiness Engineer

    9 years, 3 months ago

    With the latest updates came more functionality with the plugin, which some users may need. The problem is that now that nearly every text element on a page is wrapped in a <span> tag. This is going to cause a problem on nearly every theme out there in one way or another. CSS elements like the below will no longer function correctly:

    <br />
:first-child<br />
:nth-child( # )<br />
elem > elem<br />

    The only way I believe this can be ‘fixed’ would be to have two plugins. One that is basic and allows users to add Google Fonts to their theme and use them in the WP editor, and the other one can be more advanced to allow users to do more customization with the plugin.

    https://wordpress.org/plugins/free-google-fonts/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author KAPlugins

    (@kaplugins)

    9 years, 3 months ago

    Hi,
    can you share your site URL? I’d like to take a look at this. The main mystery here is that this plugin doesn’t modify existing CSS…

    Anyway I am waiting for your site URL.

    Thread Starter Jesse Pearson (a11n)

    (@jessepearson)

    Automattic Happiness Engineer

    9 years, 3 months ago

    The CSS isn’t changed, it’s the page structure that is changed. I create themes using the selectors mentioned before, and if an element goes from being the first child to a second child, or goes from from being a direct descendant (>) to a descendant of a span element, things get broken.

    Please email me at gfthread@jessepearson.net and I will send you an example, I cannot post here due to contract agreements.

    Thread Starter Jesse Pearson (a11n)

    (@jessepearson)

    Automattic Happiness Engineer

    9 years, 3 months ago

    Thank you for emailing me. As stated in the email, I have upgraded to the latest version and I was incorrect, it is both span and div tags.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘span tags on everything breaking layouts’ is closed to new replies.