@ symbol in image file name causes immediate unknown failure

  • Resolved archon810

    (@archon810)


    6 years, 5 months ago

    Hi Alex,

    I’m regenerating a bunch of images, and the plugin is always failing, instantly, on images with a name like this:
    “307889-PDP-Overview-SSGS7-Active-img2@2x” (ID 123456) failed to resize. The error message was: Unknown failure reason.

    I’m guessing it’s not handling the @ character correctly somehow? Any thoughts?

Viewing 9 replies - 1 through 9 (of 9 total)
  • Thread Starter archon810

    (@archon810)

    6 years, 5 months ago

    Also, oddly, this one (maybe the space in the name?):

    “carbon black-hero” (ID 455765) failed to resize. The error message was: Unknown failure reason.

    The file info is:
    “carbon black-hero
    File name: nexus2cee_carbon-black-hero.jpg”

    Edit: Actually, disregard this one. It’s an invalid jpg.

    • This reply was modified 6 years, 5 months ago by archon810.
    Plugin Contributor Alex Mills

    (@viper007bond)

    6 years, 5 months ago

    I’m nearly finished with a complete rewrite of the plugin from scratch. I’ll verify that the new version can handle @ in the filename and fix it if it can’t.

    Thanks for the report!

    Thread Starter archon810

    (@archon810)

    6 years, 5 months ago

    Awesome! A complete rewrite is pretty scary to use on a prod install right away, any chance of a quick hotfix on the current base?

    Wanted to clarify the file name on disk. It’s “nexus2cee_307889-PDP-Overview-SSGS7-Active-img2@2x.png”

    Plugin Contributor Alex Mills

    (@viper007bond)

    6 years, 5 months ago

    I plan on having some people beta test it first, but I’ve also written a ton of automated unit tests to verify that all of the plugin’s functionality works as expected.

    Anyway I can’t reproduce this on v2.x:

    “nexus2cee_307889-PDP-Overview-SSGS7-Active-img2@2x” (ID 1792) was successfully resized in 1.447 seconds.

    Do you know how to use your browser to look at the raw AJAX response?

    Thread Starter archon810

    (@archon810)

    6 years, 5 months ago

    Sure, let me check.

    Thread Starter archon810

    (@archon810)

    6 years, 5 months ago

    Afraid it’s not very helpful.

    {“error”:”"307889-PDP-Overview-SSGS7-Active-img2@2x" (ID 455763) failed to resize. The error message was: Unknown failure reason.”}

    Thread Starter archon810

    (@archon810)

    6 years, 5 months ago

    Alright, I found the issue by stepping through your code with a debugger.

    Turns out this is a misnamed webp file. It fails precisely here:
    file_is_displayable_image()

    Bah, false alarm!

    May I suggest a better error message, however?

    Plugin Contributor Alex Mills

    (@viper007bond)

    6 years, 5 months ago

    Thanks for tracking down the issue! I’ll throw some invalid images at the new code and make sure it returns useful error messages. 👍

    Plugin Contributor Alex Mills

    (@viper007bond)

    6 years, 5 months ago

    Just to follow up, tracking here:

    https://github.com/Viper007Bond/regenerate-thumbnails/issues/46

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘@ symbol in image file name causes immediate unknown failure’ is closed to new replies.