Thanks for the lightning-quick reply!
I see in that post that they are modifying the theme – I was hoping not to have to do that…
Oh hey – you’re the SVG Support plugin guy – thanks for that!
No problem 🙂
Yeah, unfortunately it’s something that will likely be unique to each theme.
If anybody runs into this in the future, I solved it by creating a simple plugin which hooks into the after_setup_theme action and adds a modified version of the add_theme_support call from the post @benbodhi mentioned.
This way the theme does not need to be modified at all…
Thanks for your feedback.
Curious, wouldn’t each theme’s dimensions be unique anyway so you’d have to edit the plugin for each theme? Or did you write it so it pulls data from the active theme?
-
This reply was modified 8 years ago by
Benbodhi.
Ha! Tried to mark as resolved, this is not my thread to mark as resolved haha.
-
This reply was modified 8 years ago by Benbodhi.
🙂
Nope – I just made a plugin for my own site because as you point out it’s custom. For this theme (xMag) all I did was:
add_action( 'after_setup_theme', 'asm_allow_svg_header' );
function asm_allow_svg_header()
{
add_theme_support( 'custom-header', array(
'flex-height' => true,
'flex-width' => true,
) );
}
(Aside: I usually have a custom plugin for each site where I do this kind of tweaking of the theme/layout/etc., so this fits well with that model.)
Hmmmm, I wonder if it would be worth including something generic like that in my plugin to work with themes out of the box… I’ll ponder. Thank you 😁
I was going to ask you about that but figured it was probably beyond the scope of your plugin. Would be great to have though! Thanks.
