support unix (linefeed-only) line endings

Resolved sankeytm
(@sankeytm)

7 years, 1 month ago
The code has a hard dependency on Windows (CRLF) line endings:

https://plugins.trac.wordpress.org/browser/csv-to-html/trunk/csvtohtml.php#L316

Please modify this plugin to automatically detect the line ending (either CRLF, or just LF) and use that as the line delimiter.

Currently this bug prevents me from using CSV files exported from Ethercalc spreadsheets.
- This topic was modified 7 years, 1 month ago by sankeytm.

Viewing 5 replies - 1 through 5 (of 5 total)

Plugin Author

(@wibergsweb)

Hi!

I were not aware of this issue. As you probably guessed I’m developing this plugin in Windows. I’m checking what could be done and I would get back to you as soon as possible.

Thread Starter

sankeytm

(@sankeytm)

7 years, 1 month ago

Maybe this approach will work:

% svn diff
Index: csvtohtml.php
===================================================================
--- csvtohtml.php       (revision 1602603)
+++ csvtohtml.php       (working copy)
@@ -313,7 +313,8 @@
                         curl_setopt($curl, CURLOPT_HEADER, false);
                         $curl_data = curl_exec($curl);
                         curl_close($curl);
-                        $file_arr = explode( "\r\n", $curl_data);
+                        // support CRLF (windows), LF (linux, mac), or CR (old mac) line endings.
+                        $file_arr = preg_split("/\r\n|\n|\r/", $curl_data);

                         //remove last item from array
                         $x = count ( $file_arr ) - 1;

Plugin Author

wibergsweb

(@wibergsweb)

7 years, 1 month ago

Hi!

Thanks for yor input! I didn’t see this answer until now, but there’s an update out there now. I hope it will work for you 🙂

Thread Starter

sankeytm

(@sankeytm)

7 years, 1 month ago

Thank you very much!

Plugin Author