Support » Plugin: Memphis Documents Library » Suggestion for changing ids to classes

Suggestion for changing ids to classes

  • Resolved merfire

    (@merfire)


    4 years, 10 months ago

    Memphis docs adds ids in every row for each cell, theses ids should be classes, for example:
    td#title, td#modified, td#download, td#file-size
    should be:
    td.mdocs-title, td.mdocs-modified, td.mdocs-download, td.mdocs-file-size.
    Ids should be unique.
    Another sugestion is to wrap two divs, navbar (div.mdocs-wrap) and content(div.mdocs-container), into another div with unique id.
    example:
    <div id=”mdocs”>
    <div class=”mdocs-wrap”>
    …
    </div>
    <div class=”mdocs-container”>
    …
    </div>
    </div>
    I think this is much better arhitecture for people to work with and it is easier for them to make changes.
    Maybe even add class for each element in file options drop down menu (Downlaod, Preview,…).
    Thanks for this plugin 🙂

    • This topic was modified 4 years, 10 months ago by merfire.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author bhaldie

    (@bhaldie)

    4 years, 10 months ago

    Yes you are correct I should use ids with the same name over and over again. I will take a look at my code and correct that issue for the next version of mDocs.

    Thanks for the report 🙂

    Thread Starter merfire

    (@merfire)

    4 years, 10 months ago

    Thank you very much for the update, architecture looks a loot better now 😀

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Suggestion for changing ids to classes’ is closed to new replies.

Views