Thank you @ja4st3r for your suggestion. I’ll add that option soon in the next version.
Phi.
Hi, thank you for considering my suggestion!
Hi @ja4st3r,
I’ve just added the hiding current page title setting to the latest version.
Thank you again for your suggestion. Please keep reporting issues and making suggestions to help the plugin grows. Please give it a rating as well to help it spread to more people.
Thanks, Phi.
-
This reply was modified 2 years, 3 months ago by
Phi Phan.
Hi Phi,
thank you very much for the update! I already tested it and it works great. I have one minor suggestion: The editor preview doesnt change, so it still shows “Dummy title”.
I was just looking at the JSON-LD Breadcrumb Schema of you plugin and I think I found a bug. I am using https://validator.schema.org/ to check the schema and get no warning, but the ‘@type’ looks off. I should be something like ListItem
or BreadcrumbList
, but in my testing it is https://example.org/BreadcrumbList
.
I think the culprit is a missing @context
in generate_breadcrumb_structured_data
. If you add something like $markup['@context'] = 'http://schema.org';
somewehere around line 465 it should work.
Regards
Yannick
Hi Yannick,
Thank you for the details. I’ll look into it soon.
Thanks, Phi.
Hi Phi,
thank you for your fast response!
I have on more suggestion. To get the name of an archive you use $post_type->labels->singular_name
, but the singular name is not the same as the archive title. If I have an archive listing books there is an important difference in meaning between ‘books’ and ‘book’. So perhaps name
would be better? (There is also the problem with prefixes, but I think there is no easy solution for it.
Is there a Github repo? I can write a pull request for both suggestions.
Kind regards
Yannick
Hi @ja4st3r,
Thank you for your suggestions, I really appreciate it. I’ll work on it soon.
What’s the problem with the prefixes? Can you explain it more?
Here is the GitHub repo.
Thanks, Phi.
Hi Phi,
sorry that I did not give you more details. I dont like the prefixes and personally dont use them.
By default WordPress adds prefixes to archive pages, e. g. “Archive” for custom post types or ‘Author’ for author archives or ‘Month’ for archives sorted by month. I think a user expects that these prefixes are “part” of the archive title and should be part of the breadcrumb trail as well.
Example:
I have a custom post type ‘book’ and list various kinds of books. I have a archive where I list all books, and the default title is ‘Archive: books’ (because it uses the prefix). One book is ‘The Hobbit’, so the breadcrumb trail would be ‘Home / book / The Hobbit’, but I think a user would expect ‘Home / Archive: book / The Hobbit’.
I have not thought about taxonomy archives or any other kind of archive. I am not sure how to deal with prefixes for these. Furthermore I am not sure if there is a easy and performant way to access the prefix outsite of the loop.
Regards
Yannick
Ah, I get it now. I’ve thought about that stuff from the beginning. In the future version, I’ll add a setting page for those labels, and prefixes configurations.
Phi.
I just add a pull request for my suggestions.
While doing that I saw that you accounted for the prefixes. I have missed that before
-
This reply was modified 2 years, 3 months ago by
yann1ck.
@ja4st3r Thank you for the pull request, I’ll work on it asap.
Phi.