Support » Plugins » Hacks » Submitting a core patch with CSS/JS modifications

  • I haven’t been able to find this info anywhere. If you’re submitting a patch to trac, and that patch includes necessary CSS or JavaScript modifications that you’ve done to the .dev versions of the script/stylesheet, are you expected to minify them and add the minified version to the patch as well? Or can one reasonably expect that that process is only done during commit?

    Is it a fair assumption that anyone testing your patch will think to set their wp-config.php to have SCRIPT_DEBUG set to true, or should one explicitly mention that in the patch comment?

    If it’s more common to expect a minified version to be patched, then can someone please point me to some instructions on which minification process / tool is generally used and what the best practices are for the WP team?

Viewing 2 replies - 1 through 2 (of 2 total)
  • Ryan Boren


    WordPress Dev

    Patches should include only changes to the .dev files. We test patches with SCRIPT_DEBUG on. A post commit hook called bumpbot minifies changed .dev files with YUI Compressor.

    Awesome, Ryan. Thanks for this.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Submitting a core patch with CSS/JS modifications’ is closed to new replies.