Submitting a core patch with CSS/JS modifications (3 posts)

  1. Tom Auger
    Posted 4 years ago #

    I haven't been able to find this info anywhere. If you're submitting a patch to trac, and that patch includes necessary CSS or JavaScript modifications that you've done to the .dev versions of the script/stylesheet, are you expected to minify them and add the minified version to the patch as well? Or can one reasonably expect that that process is only done during commit?

    Is it a fair assumption that anyone testing your patch will think to set their wp-config.php to have SCRIPT_DEBUG set to true, or should one explicitly mention that in the patch comment?

    If it's more common to expect a minified version to be patched, then can someone please point me to some instructions on which minification process / tool is generally used and what the best practices are for the WP team?

  2. Ryan Boren
    WordPress Dev
    Posted 4 years ago #

    Patches should include only changes to the .dev files. We test patches with SCRIPT_DEBUG on. A post commit hook called bumpbot minifies changed .dev files with YUI Compressor.

  3. Tom Auger
    Posted 4 years ago #

    Awesome, Ryan. Thanks for this.

Topic Closed

This topic has been closed to new replies.

About this Topic