Submit pull request?

  • mikethicke1

    (@mikethicke1)


    2 years, 7 months ago

    Currently Zotpress_install() is called whenever there is a change to the database structure. This function drops and re-creates each table, which has the effect of losing the user’s account data. Since dbDelta can update table structure in-place, I suggest not dropping current tables for database updates. However, I see that dropping these tables was added in 2019, so perhaps there was an issue that I’m not aware of?

    We run a multisite with about 100 sites that use zotpress, so we’ve been stuck on zotpress 6.2.4 for a while now because we don’t want our users to lose their account settings. I created a fork here: https://github.com/MESH-Research/zotpress and a PR here: https://github.com/MESH-Research/zotpress/pull/1 with my (minor) changes. If these changes don’t break anything we’d be very happy for them to be incorporated into your plugin so that we don’t have to maintain a forked version and other users of the plugin don’t have to re-enter their account information when updating.

    Thanks!

Viewing 3 replies - 1 through 3 (of 3 total)
  • pvanheus

    (@pvanheus)

    2 years, 6 months ago

    If you don’t mind, I’ll add to this thread because I’m trying to understand the development model for Zotpress. I’ve made a small change to allow multiple strings to be used with “highlight” and I’d also like to submit a pull request. Is the SVN code repository the canonical location for the code? I.e. there’s not Git / Github repository to PR against?

    My understanding is the at Zotpress is in “maintenance mode” so, are non-bugfix changes still being accepted? Its an amazing plugin and I’d love to contribute to it. Perhaps @kseaborn can comment?

    Mark

    (@codeispoetry)

    2 years, 6 months ago

    Am really hoping @kseaborn is open to contributions of this kind! I might have some small contributions to make as well.

    Plugin Author Katie

    (@kseaborn)

    2 years, 6 months ago

    Hi all. Yes, basically in hibernation. It’s pretty much been me alone developing with people sending me code over email at various points. I only use the WP SVN. If you can find my personal website you can find the Zotpress tracker at /zptracker and see a very rough and usually outdated roadmap. tbh it’s been a very very long time since I’ve directly collaborated on code with others so I’m not sure the best way forward. If it’s small stuff, perhaps you can just post the code here?

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Submit pull request?’ is closed to new replies.