WordPress.org

Forums

Custom Favicon
[resolved] SSL Support (3 posts)

  1. William Earnhardt
    Member
    Posted 1 year ago #

    On line 115 of custom-favicon.php your plugin enqueues the javascript file for the admin using WP_PLUGIN_URL.

    This means the js file is blocked on modern browsers by default if you are using SSL admin because it tries to load the file over http instead of https.

    The proper way to do this is to use plugins_url(), as noted here: http://codex.wordpress.org/Determining_Plugin_and_Content_Directories

    WordPress makes use of the following constants when determining the path to the content and plugin directories. These should not be used directly by plugins or themes

    I've patched this on my local version, any chance you can add this to your next update?

    https://wordpress.org/plugins/custom-favicon/

  2. Harish Chouhan
    Member
    Plugin Author

    Posted 1 year ago #

    Thanks @earnjam William.
    I will definitely update the plugin with the code you suggested. Thanks again for helping to improve it.

  3. William Earnhardt
    Member
    Posted 1 year ago #

    That's great, thanks! I'll mark this as resolved.

Topic Closed

This topic has been closed to new replies.

About this Plugin

  • Custom Favicon
  • Frequently Asked Questions
  • Support Threads
  • Reviews

About this Topic

Tags

No tags yet.