Viper's Video Quicktags
SSL & Schemeless URLs for embed tags (2 posts)

  1. YellowShark
    Posted 2 years ago #

    Hey there Mr. Developer, would like to point out something I had to mod in your code, in order to make things play nice over SSL. In /vipers-video-quicktags.php, line 3166, from VipersVideoQuicktags->shortcode_vimeo(), this code here:

    $iframeurl = 'http://player.vimeo.com/video/' . $videoid;

    Works better if modified to this:

    $iframeurl = '//player.vimeo.com/video/' . $videoid;

    You're actually forcing non-ssl http all over the place, from $this->default_settings in the constructor, through most of the shortcode_* methods, and likely beyond. I think it's pretty safe these days to just use the schemeless "//" protocol for almost all URLs, assuming of course that the respective services support SSL on an individual basis. Most of the big guys do though, YouTube & Vimeo for sure. Anyhow, thanks of course for the code, much respect & thanks. Holler if I can be of any assistance whatsoever :)


  2. idleberg
    Posted 2 years ago #

    while i don't like messing in a plugin's code, i was very happy to have come across this. thanks!

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic