Support » Plugin: Easy Digital Downloads » Span change kill theme

  • Resolved kbarcza

    (@kbarcza)


    Hello,

    Latest version 2.8.16, 21 December 2017 with the following:
    -> Fix: Changing span elements for div elements for schema markup.

    This upgrade kill the my page structure (mediaphase theme).
    I can put back from backup and page look great again.
    The part of probelm is:

    --- easy-digital-downloads.old/includes/template-functions.php  2017-12-20 15:55:31.000000000 +0100
    +++ easy-digital-downloads/includes/template-functions.php      2017-12-28 00:57:54.000000000 +0100
    @@ -831,7 +831,7 @@
    
            if ( $query && ! empty( $query->query['post_type'] ) && $query->query['post_type'] == 'download' && is_singular( 'download' ) && $query->is_main_query() ) {
                    $microdata_open = true;
    -               echo '<span itemscope itemtype="http://schema.org/Product">';
    +               echo '<div itemscope itemtype="http://schema.org/Product">';
            }
    
     }
    @@ -856,7 +856,7 @@
    
            if ( $post && $post->post_type == 'download' && is_singular( 'download' ) && is_main_query() ) {
                    $microdata_close = true;
    -               echo '</span>';
    +               echo '</div>';
            }
     }
     add_action( 'loop_end', 'edd_microdata_wrapper_close', 10 );
    
    • This topic was modified 1 year, 9 months ago by  kbarcza.
    • This topic was modified 1 year, 9 months ago by  kbarcza.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author mordauk

    (@mordauk)

    This change had to be done in order to correct invalid markup in previous versions. See https://github.com/easydigitaldownloads/easy-digital-downloads/issues/6232

    To resolve the issue, please update the CSS accordingly of your theme. If you’re unable to do that yourself, please contact your theme’s developer and ask them to issue an update that takes care of the problem.

    Plugin Author mordauk

    (@mordauk)

    After some more investigation we have found additional cases where this caused a problem so we have reverted the change.

    Please update to Easy Digital Downloads version 2.8.17 to take care of the issue.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Span change kill theme’ is closed to new replies.