Spacing, no style or background color choices

Resolved vcor2
(@vcor2)

7 years, 10 months ago

Running into several issues with 1.8.6 (downloaded today):
1) There is a lot of whitespace added after the button. About 10 lines or so. The raw code shows nothing between the shortcode and the next line of text.
2) The nice colorful buttons you show in the examples do not appear. I get a rectangular gray button. In the settings, design, Images & Layout, where I suspect a button should appear there is the text in a box “MeliBu WP Download Counter Button Logo”. When you click on choose file, it drops me into my local “E:/Temp” directory where there is nothing useful to select.
3) Colors do not work well. Icon colors only changes the color of a thin green vertical line. Button colors changes the text color, but not what is indicted. “Black Flat” shows white text in the Preview button. Label colors does nothing. None of the color choices changes the background, which is always dark grey.

I have no problem with the actual button working – it does count clicks and does jump to the URL.

Viewing 7 replies - 1 through 7 (of 7 total)

Plugin Author prod3v3loper
(@prodeveloper)

7 years, 10 months ago
First thank you for your feedback @vcor2.

1) This is not a blank space, but a margin distance down, because if the label was connected sufficient space to the content still remains. However, in the next version, i adjusted the distance a bit.

2) The beautiful colorful Buttons, first, a style button of the default button would have to be normal, which simply change as desired, colors can be put together by selecting a color for the respective area and then clicking on save the color. The gray button is a default setting. The area with the download is only for the logo label, which will be visible when the label has been activated in the settings.

To make a download you have to go to a new or existing contribution or even go to the editor and there you find a download short code, if you click there you open your media library and can select a meaningful file to download, if available: ).

3) There was definitely an error that I now correct and in the version 1.8.6.1 no longer be available, so download and try the same.

Best regards
- This reply was modified 7 years, 10 months ago by prod3v3loper.
Thread Starter vcor2
(@vcor2)

7 years, 10 months ago

Thanks! That worked. Great little addition.

Experimenting a bit more, if I activate the Settings-> Button -> Label, it includes the quotes in the display. Perhaps these should be removed when displayed. I got around it by not using quotes and using underscores for spaces in the shortcode (not ideal, but works).

I also got two lines No Type and No Size in the label area. Here’s a sample label before removing quotes:
“App Name”
“29-Oct-2016”
No Type
No Size
“v1.02”

Not sure how to remove type/size or add values. The download goes to Dropbox, rather than a direct file download.

Plugin Author prod3v3loper
(@prodeveloper)

7 years, 10 months ago

Not for that, gladly, I have to thank for your feedbacks, I would be glad about a review, if you leave one behind 🙂

So with the label and quotes I did not quite understand why you quotes in there have in the display and there are no blank spaces in the label name?

Can you possibly make a screenshot, then I could make a better picture. You can upload a picture on a free platform and embed it so you can see the image, because underlined are not the meaning, it should work without underscores wei with me also, if I understood you correctly.

No type/size I have now fixed for files which are attached by remote, in the next version v.1.8.6.2 they will determine from dropbox or any platform, it is the it is a donwloadable file.

Best regards

Thread Starter vcor2
(@vcor2)

7 years, 10 months ago

Thanks for looking into this.

Here’s a screenshot:

And the tag looks like:
[wp_mb_plugin_download instance=”1″ name="Download" datetime="29.10.2016" other="v1.2"]https://www.dropbox.com/s/xxxxx/TORG-Setup.exe[/wp_mb_plugin_download]
Plugin Author prod3v3loper
(@prodeveloper)

7 years, 10 months ago
So with me your shortcode creates an error, I do not know if you have WP_DEBUG on, if not the errors are not shown to you.

Notice: Undefined index: instance in /wp-content/plugins/download-counter-button/classes/class.MelibuFrontend.php on line 260

Your shortcode:
[wp_mb_plugin_download instance=”1″ name="Download" datetime="29.10.2016" other="v1.2"]https://www.dropbox.com/s/xxxxx/TORG-Setup.exe[/wp_mb_plugin_download]

instance=”1″ Here you have two different quotes, that could cause the error. ” / ″ These are not WP editor quotes.

name="Download" And here you have the right quotes, which come in the WP editor when you type. " The right quote.

Please try:
[wp_mb_plugin_download instance="1" name="Download" datetime="29.10.2016" other="v1.2"]https://www.dropbox.com/s/xxxxx/TORG-Setup.exe?dl=1[/wp_mb_plugin_download]

And for DropBox downloads please, check here:
doesnt-work-with-dropbox-links

Try it with the right quotes if it still spits the same error then sign up again and I help you.

Best regards
- This reply was modified 7 years, 10 months ago by prod3v3loper.
- This reply was modified 7 years, 10 months ago by prod3v3loper.
- This reply was modified 7 years, 10 months ago by prod3v3loper.
Thread Starter vcor2
(@vcor2)

7 years, 10 months ago
Thanks- don’t know how I got the wrong quotes in there. With ASCII quotes, it works fine. I updated to Version 1.8.6.2 today as well.

I still get the “no size”, and the previous “no type” appears as “e”. Here’s a direct link to the page with the button, as it should be easier to see in operation.

http://teslatap.com/torg-music-organizer/torg-release-notes/

Perhaps if there were overrides in the short-code, I could just insert the correct type and size?
Here is the current shortcode too:
[wp_mb_plugin_download instance="0" name="TORG-Setup.exe" datetime="30-Oct-2016" other=v1.03]https://www.dropbox.com/s/r3b0zykfd7d1jat/TORG-Setup.exe?dl=0[/wp_mb_plugin_download]
- This reply was modified 7 years, 10 months ago by vcor2. Reason: Forgot shortcode
Plugin Author prod3v3loper
(@prodeveloper)

7 years, 10 months ago
No problem, do not forget my stars 🙂
Thanks for the screenshot, the links, your shortcode and your help

You have an exe file to the download selected, because you did not send the actual link before I could not test it. So I had a jpg file to test selected because ran it, now I have it fixed, now it would have to work with any file type.

Here is a screenshot have it tested error free now and it aired, hope could help you.

In the next v.1.8.6.3 or higher the correct data will be displayed, much fun with the next version.

TIP: And please use in the short code no instance starting with 0 instance="0xxx" (bad), i have it in a screenshot but with zero starting instance are error prone, better starting with 1 instance="1xxx" (good).

Best regards
- This reply was modified 7 years, 10 months ago by prod3v3loper.