Song pages not found

Viewing 6 replies - 1 through 6 (of 6 total)
  • Thread Starter jfrocksguitar

    (@jfrocksguitar)

    9 years ago

    I found your issue. It would seem that the links that work from the original version look like this, http://www.jfrocksguitarlessons.com/jeff-fiorentino-blog/?ms_song=forgotten

    Note the question mark before the ms_ portion of the link. In the new version 1.0.11 there is no question mark, the links for existing songs look like this, http://www.jfrocksguitarlessons.com/jeff-fiorentino-blog/ms_song/forgotten

    Note there is no question mark prior to the ms_ = So you need to do another update that fixes the link issue and doesn’t change song purchase page link format it would seem.

    Please fix this. Of course don’t fix it by changing our existing song links, as that would mean an overhaul of my and others’ entire music store pages. i.e. we would have to change every link. Please fix this within your own plug-in and be sure the question mark is in there.

    Regards,
    Jeff

    Thread Starter jfrocksguitar

    (@jfrocksguitar)

    9 years ago

    Serious flaw here guys..

    Also because this question mark in the link is missing, we cannot add new songs as all the links are processing in an incorrect format the lead to a page cannot be found status. I just created a “test” page in an attempt to add a new song, and it too had no question mark in the permalink and lead to a page cannot be found situation. http://www.jfrocksguitarlessons.com/jeff-fiorentino-blog/ms_song/test/

    Adding the question mark after the fact by the way, does nothing. In fact it just creates a default back to the main blog page itself.

    Again please fix this version or send me a link to version 1.0.10 as that version worked great. I need to be able to add new songs for god’s sake.

    Please read my previous and test the links provided to see what I mean. I’m sure this isn’t just a problem I’m having and others will have it too, as if the links to the songs don’t work, what’s the point.. LOL..

    Regards,
    Jeff

    Thread Starter jfrocksguitar

    (@jfrocksguitar)

    9 years ago

    Well I ended up fixing it myself by restoring the music store file on my website back to yesterday prior to the update to this new non-working 1.0.11 version.

    However, I do think you should address this issue for others. As eventually they will be checking their song links and noticing that they don’t work because they’re missing the ? in front of the ms_

    Plugin Author codepeople

    (@codepeople)

    9 years ago

    Hi,

    I’m sorry for delay, I’ve not received the notifications of your tickets in the support page of the plugin.

    The latest version of the plugin allows to use the struture of permalinks defined in your website, the previous version was imposing a rigid structure for the URLs of the songs (not friendly URLs). I’ve tested the latest version of the plugin in different contexts, and has worked fine in all of them. However, if you want to use the previous structure of the URLs, follows the steps below:

    1. Open the “/wp-content/plugins/music-store/music-store.php” file with the text editor your choice.

    2. Go to the code for registering the new post type:

    register_post_type( 'ms_song',
array(
	'description'		   => __('This is where you can add new song to your music store.', MS_TEXT_DOMAIN),
	'capability_type'      => 'post',
	'supports'             => array( 'title', 'editor', 'thumbnail' ),
	'exclude_from_search'  => false,
	'public'               => true,
	'show_ui'              => true,
	'show_in_nav_menus'    => true,
	'show_in_menu'    	   => $this->music_store_slug,
	'labels'               => array(
		'name'               => __( 'Songs', MS_TEXT_DOMAIN),
		'singular_name'      => __( 'Song', MS_TEXT_DOMAIN),
		'add_new'            => __( 'Add New', MS_TEXT_DOMAIN),
		'add_new_item'       => __( 'Add New Song', MS_TEXT_DOMAIN),
		'edit_item'          => __( 'Edit Song', MS_TEXT_DOMAIN),
		'new_item'           => __( 'New Song', MS_TEXT_DOMAIN),
		'view_item'          => __( 'View Song', MS_TEXT_DOMAIN),
		'search_items'       => __( 'Search Songs', MS_TEXT_DOMAIN),
		'not_found'          => __( 'No songs found', MS_TEXT_DOMAIN),
		'not_found_in_trash' => __( 'No songs found in Trash', MS_TEXT_DOMAIN),
		'menu_name'          => __( 'Songs for Sale', MS_TEXT_DOMAIN),
		'parent_item_colon'  => '',
	),
	'query_var'            => true,
	'has_archive'		   => true,
	//'register_meta_box_cb' => 'wpsc_meta_boxes',
	'rewrite'              => true
)
);

    and modifies only the line of code:

    ‘rewrite’ => true

    to

    ‘rewrite’ => false

    and that’s all.
    Best regards.

    Thread Starter jfrocksguitar

    (@jfrocksguitar)

    9 years ago

    Well I appreciate the response. But to be honest I’m going to leave the older version there. I’m a true believer in something most coders aren’t and that’s the old adage, “if it ain’t broke, don’t fix it”

    If there’s a need to go into the code of the plug-in to fix an issue, then that should be put in the notes of the download. The average Joe isn’t going to know how to or even want to do this. Your new update changed the nomenclature of the song urls omitting the question mark, and making posting of new songs link to a “page not found page”. That said, it should be defaulted to your “false” setting if this is the case. I assure you this will happen to others as well. It’s not an issue confined to me.

    Regards,
    Jeff

    Plugin Author codepeople

    (@codepeople)

    9 years ago

    Hi,

    If you tick the “Default” option in the permalinks section of your WordPress, the structure of the songs URLs would be as in previous versions of the plugin. We’ve modified our plugin, because many customers have requested the possibility of use friendly URLs in the songs for SEO reasons.

    Best regards.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Song pages not found’ is closed to new replies.