Hi Pavel
You’re right that v3.2.13 works – the issue I have is that older versions had a security vulnerability which was significant enough to get the plugin put into WP’s review process -> https://wpscan.com/vulnerability/bbcece1e-45c1-4b40-8b14-aedee6aa23cd It was also flagged by my host (Kinsta) so I can’t run an older version.
It’s a real shame because fixing the security issue has broken some of the original functionality.
Many thanks!
hello @outerbridge and @pavelmares ,
My bad, I fixed gettext filter in 3.2.20 version.
Please update the plugin and let me know if everything is OK 🙂
Additionally please check if you have necessary themes and plugins selected in tab (In admin dashboard): Languages -> TTfP Settings.
Regards.
@marcinkazmierski seems fixed, thank you
-
This reply was modified 3 years, 4 months ago by
Pavel Mares.
@pavelmares great, and sorry for delay 🙂
Hi Marcin @marcinkazmierski
Thank you for this. Unfortunately, it’s still not working for me – v3.2.23.
I think it may be related to the headings h1 to h6, buttons, etc.
Regards
Outerbridge
@outerbridge please update plugin to 3.3.0 and check settings on TTfP Settings page.
Hi @marcinkazmierski
Thank you for your efforts with this. I’ve done as you said and checked the Settings page as well as update the plugin to v3.3.1 but it’s still not working. :-/
Regards
Outerbridge
@marcinkazmierski If you’d like me to do anything to help you with this, I’m very happy to help – just let me know…
@outerbridge can you share code snipet with translation problem?
function with text that is not translated
Hi @marcinkazmierski
I have a class with some shortcodes in it.
The first works:
function __construct() {
...
add_shortcode( 'obr_job_archive_strapline_wording', array( $this, 'obr_job_archive_strapline_wording' ) );
...
}
function obr_job_archive_strapline_wording( $atts, $content = null ) {
$returnstring = __( 'Which adventure will you choose?', 'wacom' );
return $returnstring . $content;
}
But the second doesn’t:
function __construct() {
...
add_shortcode( 'obr_job_archive_header_wording', array( $this, 'obr_job_archive_header_wording' ) );
...
}
function obr_job_archive_header_wording( $atts, $content = null ) {
$returnstring = __( 'Our Jobs Abroad', 'wacom' );
return $returnstring . $content;
}
They look very similar. The only difference that I can think of is that the first is wrapped in a <h1>. That may not be the problem though…
Many thanks for your assistance Marcin.
Regards
Outerbridge
@outerbridge can you also share screenshot of “TTfP Settings” in your dashbord (“Languages” > “TTfP Settings”) ?
Hi @marcinkazmierski
Please see the attached screenshot -> https://imgur.com/a/1E4ZR7f
Many thanks
Mike
@outerbridge ok, thank you,
I already know everything, your theme is not named like your custom domain: “wacom”, so you need to do:
- rename domain ‘wacom’ to exactly what your theme is called (‘workingadventureschild-com’ from your screenshot)
or
2. modify list of text domains by ‘ttfp_domains’ filter and select it on “TTfP Settings” page:
add_filter('ttfp_domains', 'custom_ttfp_domains', 10, 1);
function custom_ttfp_domains(array $domains)
{
$domains[] = "wacom";
return $domains;
}
List of text domains is displayed on “TTfP Settings” page to select them for translation by polylang engine.
Hi Marcin @marcinkazmierski – that was the problem, thank you for investigating and helping resolve the problem!
Regards
Outerbridge
