WordPress.org

Forums

Magazine Basic
Some Translations fixes (9 posts)

  1. cheche
    Member
    Posted 1 year ago #

    Hi,
    I made some changes on your code to accommodate the Spanish translation,it would be nice if you can incorporate those changes to the main trunk.

    you can download those changes here:
    https://github.com/juanjosepablos/magazine-basic-fix

  2. jastray
    Member
    Posted 1 year ago #

    Hola Cheche,

    I'm newbie in wordpress, and I don't know exactly what I have to do. Just copy the files you have shared into the magazine basic directory?

  3. cheche
    Member
    Posted 1 year ago #

    I have it on :

    Copy es_ES.* from https://github.com/juanjosepablos/magazine-basic-fix/tree/master/library/languages to:

    wordpress/wp-content/themes/magazine-basic/library/languages

  4. jastray
    Member
    Posted 1 year ago #

    Hi Cheche, Is not working but probably because I have not downloaded it correctly.

    I have not found a download link for any of the files. I have clicked on es_ES.mo "Raw" and efectively downloaded the file, but doing the same for es_ES.po what you get apparently is the content of the *.mo file. I have copied and pasted to a new es.ES.po on my environment. Then I have copied them to ../wp-content/themes/magazine-basic/library/languages. Nothing has changed.

    BTW, I'm using a child theme, but I have installed the es_ES.* on the mother theme not on the child

  5. jastray
    Member
    Posted 1 year ago #

    Hi,

    I have finally managed to install what Cheche kindly shared. GitHUB is a bit tricky for not developers, but finally succeed. It is relevant to share that Cheche's fix make the Theme

    fully valid to translate to any language
    . Only requires the corresponding .po file.

    There is just one bug still existing: Comment's text does not translate. I have tried to correct it but my lack of PHP knowledge impedes it.

    What needs to be corrected is this sentence in comments.php file:

    <?php if ( have_comments() ) : ?>	<h2 id="comments-title">
    <?php	printf( _n( '1 comment for &ldquo;%2$s&rdquo;', '%1$s comments for &ldquo;%2$s&rdquo;', get_comments_number(), 'es_ES' ),

    Currently, the result is that "1 comment" or "X comments for" does not translate.

    It would be great is someone can provide the correct php code.

  6. cheche
    Member
    Posted 1 year ago #

    ok. I will have a look.

  7. cheche
    Member
    Posted 1 year ago #

    PHP code is fine. The only problem is that is plural. so you need to fix a couple of issues.
    I notice that there is some typo on the language domain.
    https://github.com/juanjosepablos/magazine-basic-fix/commit/fbf5807d032b56fe44925bcb034df441d0353d1e

    maybe you would like to fix them as well

  8. jastray
    Member
    Posted 1 year ago #

    Thanks Cheche,

    Effectively, there was the typo error on the language domain. I have made the changes from "basic-magazine" to "magazine-basic" but the comments text remains non translated.

  9. cheche
    Member
    Posted 1 year ago #

Topic Closed

This topic has been closed to new replies.

About this Theme

About this Topic

Tags