Some bugs on my test installation

  • evangelicalmagazine

    (@evangelicalmagazine)


    5 years, 7 months ago

    I’ve installed the plugin. Firstly a minor bug, a PHP notice.

    Accessing static property Fb_Gf_Gocardless_Hosted::$has_this_feed as non static.

    The error is triggered by line 185 of class-fb-gf-gocardless-hosted.php

    Also, it took me a very long time to work out that when the documentation says “Settings”, it means the settings of the specific form. I was looking on the Gravity Form settings page.

    There’s also a more serious bug on line 497 of class-fb-gf-gocardless-hosted.php. There the gocardless_direct_debit_amount is cast to (int) BEFORE being multiplied by 100. It should be cast to (int) AFTER this operation, otherwise only whole pounds can be debited.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Thread Starter evangelicalmagazine

    (@evangelicalmagazine)

    5 years, 7 months ago

    Sorry, but I’ve found another bug. This time line 516.

    $success_redirect_url = get_permalink( $confirmation['url'] );

    should be

    $success_redirect_url = $confirmation['url'];

    I’ve corrected these bugs and added a few filters to allow me to take annual or monthly payments, not just one-off payments. Let me know if you’d be interested in receiving these.

    Thread Starter evangelicalmagazine

    (@evangelicalmagazine)

    5 years, 7 months ago

    I’ve put the changes I’ve made on GitHub. I’m very happy for them to be merged into the code.

    https://github.com/markbarnes/GoCardlessForGravityForms/commits/master

    Plugin Author fatbeehive

    (@fatbeehive)

    5 years, 7 months ago

    Hi Mark,

    Thanks for flagging this with us and fixing the bugs you encountered.

    We’ll take a look through your changes this week and look to merge them in ASAP.

    Thanks again,
    Stuart

    Thread Starter evangelicalmagazine

    (@evangelicalmagazine)

    5 years, 7 months ago

    Thanks. Ideally, it would be nice to be able to set a one-off payment or a recurring payment (and the interval) in the feed settings in Admin. But the filters were a quick way of achieving the same thing.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Some bugs on my test installation’ is closed to new replies.