SO tabs stopped working – related to WP 4.6 update?

  • Resolved David

    (@david_kissinger)


    7 years, 8 months ago

    Hi all,
    Livemesh tabs suddenly stopped working on my page. Rather than switch between tabs, the inactive tabs scroll down while the active tab scrolls up. Help! This is a production site that I’m adding required content to for a client.

    Here is the page:
    http://www.southbayaor.info/southbay/torrance/

    Other widgets and the SO page builder still work. For example, on another test page I installed tabs and accordion next to each other. The accordion worked but the tabs did not.

    The conflict shows up inside includes\widgets\lsow-tabs-widget\js\tabs.js. I confirmed that this file was correctly enqueued on my page. The methods for the LSOW_Tabs are all available, and there are no errors on the console.

    However, the methods LSOW_Tabs.prototype.show and LSOW_Tabs.prototype.makeResponsive, while available, are not firing at all. When I click on a tab, the show method doesn’t work and when I resize the window or test it for responsive in my browser, the method makeResponsive does nothing. In fact, the entire window does not resize into responsive mode which makes me think that either JavaScript has stopped working on the page or that another JS script is somehow blocking the events from tabs.js. This problem came up yesterday shortly after I updated to WP 4.6, and it worked for weeks beforehand. I haven’t changed any of my other plugins so I don’t think that there are incompatibilities with them.

    Is this related to the WP 4.6 update? Is there a quick monkey patch I can put in until it is corrected?

    Please let me know what to do! I love these widgets but I cannot keep them on my production site if I can’t resolve this conflict.

    Thanks!

    # # #

    Here is my stack:
    WP 4.6
    Livemesh SO Widgets 1.4.2 (Just updated today; the issue still exists)
    SO Page Builder 2.4.13
    SO CSS 1.0.8
    SO Widgets Bundle 1.6.5

    https://wordpress.org/plugins/livemesh-siteorigin-widgets/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author livemesh

    (@livemesh)

    7 years, 8 months ago

    The issue lies with theme script north.min.js which has some scroll related functions which are intercepting the click events and probably not propagating them thereafter (hence failing to reach tabs.js script). Pls check with the North theme support on this and they should be able to point you to the cause of this issue.

    Thread Starter David

    (@david_kissinger)

    7 years, 8 months ago

    @livemesh Thank you! That was in fact the cause of the issue. In particular, it is caused by SO North’s usage of Smooth Scrolling and this appears to cause a conflict with LSOW Tabs that can be resolved only by disabling Smooth Scroll in SO North.

    A recent commit expanded smooth scrolling to the entire site. The smoothScroll method fires when it sees an anchor link such as href="#abcde' on the page.

    This is a problem specifically for Livemesh tabs because each individual tab is identified by an anchor. The result is that when Smooth Scroll is enabled (in the Customizer), it overrides all the tab events from LSOW Tabs, and the screen tries to scroll instead of switching to another tab.

    This seems to represent an incompatibility for LSOW Tabs. It cannot be used in SiteOrigin North unless Smooth Scrolling is disabled or unless either SO North or LSOW Tabs is updated to account for the tabs’ usage of anchors to make the tab functionality work.

    Plugin Author livemesh

    (@livemesh)

    7 years, 8 months ago

    We have the internal links for the tabs so that users can navigate to the content, just in case the script fails for some reason or if script needs to be disabled. With simple one line CSS change, the internal links can be used to navigate to the corresponding content from the tab title.

    You should ask the theme support to at least propagate the click events for other handlers like ours. This change can potentially break other plugins that deal with internal links.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘SO tabs stopped working – related to WP 4.6 update?’ is closed to new replies.