Slight problem with SSO by Google simple Connect

Rolf Allard van Hagen
(@ravanh)

11 years, 2 months ago

Hi Ron, Curtiss, Scribu and (if you’re listening – I added a tag) Otto,

I just ran in to a little snag with a site on a network installation where I have Simple Google Connect running to allow users to identify with SSO. But now the site needs to go behind a login and I tried Network Privacy which works great except when trying to connect through SSO.

Whet happens is this: the login screen comes up and after hitting the SSO button the popup window with Google login form comes up (all normal here still) but after login, the popup window does not disappear like normal (redirecting to the dashboard) but instead shows the WordPress login form where my username is filled in. Nothing to indicate that there was a successful connection, nor any error messages.

The funny thing is that the connection was in fact successful because when I close the popup (ignoring the login form in that window) and hit the “Return to site” link below the original login form, the site is suddenly accessible and I’m connected 🙂

So it seems to be just a redirection problem.

I have activated Network Privacy on the network with the default empty setting (meaning ‘all open’, I presume?) and then set this particular site to allow only Subscribers (and up, I presume?).

Note: I also tried the plugins More Privacy Options and Multisite Privacy (from WPMUDEV) but these two actually do NOT work at all in combination with SSO by Simple Google Connect.

http://wordpress.org/extend/plugins/network-privacy/

Viewing 4 replies - 1 through 4 (of 4 total)

Thread Starter Rolf Allard van Hagen
(@ravanh)

11 years, 2 months ago
OK… found it.

On line 40 in ra-network-privacy.php there is
```
add_action( 'template_redirect', array( $this, 'authenticator' ) );
```
which I changed to
```
add_action( 'template_redirect', array( $this, 'authenticator' ), 11 );
```
and now after login all users land on the dashboard page like usual with Simple Google Connect.

Wonder if
```
add_action( 'bp_screens', array( $this, 'authenticator' ), 0 );
```
needs to be changed too when working with BP…

I suppose it would also be possible to change line 330 in sgc-base.php from
```
add_action('template_redirect','sgc_oauth_catcher');
```
to
```
add_action('template_redirect','sgc_oauth_catcher', 9);
```
but I’ve no idea how this would impact plugin behavior in other cases.

Can anyone advize me on which of these methods (if at all) would be the safest? Thanks 🙂
Plugin Author Ron Rennick
(@wpmuguru)

11 years, 2 months ago

I think we all left this one for the others. I don’t know that any of us use Network Privacy with BP.
Thread Starter Rolf Allard van Hagen
(@ravanh)

11 years, 2 months ago
I asked Samuel about what the impact of the change
```
add_action('template_redirect','sgc_oauth_catcher', 9);
```
to his plugin would be on http://wordpress.org/support/topic/request-privacy-plugins-compatibility but for now, the modification
```
add_action( 'template_redirect', array( $this, 'authenticator' ), 11 );
```
to Network Privacy seems to be doing fine although I have not tested it much with other sites/settings in the network … Nor with BuddyPress, but i guess it would be very rare, a private buddypress site. 😉
Plugin Author Ron Rennick
(@wpmuguru)

11 years, 2 months ago

I won’t have time to look at it for a bit (see your other thread) but the change to 11 looks like it should be fine.

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Slight problem with SSO by Google simple Connect’ is closed to new replies.