WPML version 4.4.5 is available with the fix for this issue.
Could you update and let us know if the issue is resolved for you?
Thread Starter
markjl
(@markjl)
Hello. Thank you very much indeed for the update, WPML 4.4.5 solves the problem. What a relief, back to normal. Now I can get on and sort out my SEO !!
It seems to have sorted the problem for us too.
(However, WPML does not signal that there’s an update available so one has to go and look for it manually.)
I will keep a lookout to see if it stays well.
Thank you.
Thanks so much for the confirmation and your patience during this time. I’m glad to hear all is working properly now!
Thread Starter
markjl
(@markjl)
I’m disappointed to announce that the issue is not completely solved.
Site kit stays connected when you swap from language to language.
But still disconnects if you select ‘All languages’ and then back to a single language
@markjl really appreciate your report again! I am able to recreate the issue and have shared this with our team. I’ll follow up with more information when I have it.
@markjl we’re contacting WPML to look into this, so we’ll follow up when the fix is available. Thanks again!
Hi @markjl,
I am Pierre from WPML’s compatibility team.
Indeed, thsi “all” language case does not have the expected behaviour.
I think we need to change our strategy to keep things simple. Could you please edit the file wp-content/plugins/sitepress-multilingual-cms/compatibility/GoogleSiteKit/Hooks.php and replace:
public function getCanonicalHomeUrl( $homeUrl ) {
$filteredHomeUrl = apply_filters( 'wpml_permalink', $homeUrl, apply_filters( 'wpml_default_language', '' ) );
$filteredHomeUrl = trim( filter_var( $filteredHomeUrl, FILTER_SANITIZE_STRING ) );
return $filteredHomeUrl ?: $homeUrl;
}
With:
public function getCanonicalHomeUrl() {
/** @var \WPML_URL_Filters $wpml_url_filters */
global $wpml_url_filters;
$wpml_url_filters->remove_global_hooks();
$unfilteredHomeUrl = home_url();
$wpml_url_filters->add_global_hooks();
return $unfilteredHomeUrl;
}
Let me know if that works in all situations.
Thanks,
Pierre – WPML
@strategio
Are you seriously suggesting that in order to make your plugin work correctly every user needs to edit some code?
I can’t see that as an acceptable solution in the longer term.
As a short term fix for a few days or a week until you find a solution, well, ok maybe (but that’s really stretching it).
As a permanent solution – no way!
Hi @bkwineper,
Are you seriously suggesting that in order to make your plugin work correctly every user needs to edit some code?
No, that’s not what I am suggesting, but maybe my last comment was not clear.
I would just like to have a confirmation that this solution works for you in all contexts.
If yes, you can leave the patch on your install and we’ll include it in the next WPML release.
For your information, the issue is not completely on WPML, but we accepted to have some compatibility code on our side.
Thanks,
Pierre
Hi @strategio
Ok, agree, your previous comment was not quite clear. If you plan to find a solution in a future release, that’s good. Thank you.
I do understand that it is not necessarily 100% a WPML issue, but from a user perspective it is horrible complex to deal with a situation when a plugin developer says “it’s not us, it’s them” (I know, I’m dealing with another situation where WPML, Elementor and Yoast are all involved…). But the fact that you are in this case really working together with Site Kit is very good! I wish it happened more often.
I will let @markjl respond to if the suggested fix/patch works.
Many thanks for everyone’s helpful reports, collaboration, and patience as we work toward resolution. The remaining fix is planned to be released in the next version of WPML 4.4.7. We’ll follow up when it is available.
I have the same issue with my site.
I do not use WPML, but using other plugin called ‘TranslatePress – Translate Multilingual sites’. I believe the issue occurred during the translation.
This is a really critical issue, because Site Kit connects the Tag manager and the Tag manager handles the Barion Payment!
Please investigate the issue.
Same issue. Using WPML v 4.4.6
Different languages in directories (as opposed to different domains).
WPML version 4.4.7 has just been released with the remaining fix to address the issue with the “All languages” admin bar setting. Could you update at your convenience and let us know if the issue is resolved for you?
@lewstyle15 thanks for reporting. We’ve been trying to replicate the issue using TranslatePress. In a new topic, could you send us a recording and/ or a detailed step-by-step of what causes the issue on your site? You can use an app like Recordit to make a video. Many thanks!
