• Resolved Keith_Saunders

    (@keith_saunders)


    Now got following error since update 2 days ago on the top of each thread in the forum. Only seen by logged in members..

    Warning: Trying to access array offset on value of type bool in /homepages/17/d531871193/htdocs/clickandbuilds/BeoworldForum/wp-content/plugins/bbp-style-pack/includes/functions.php on line 372

Viewing 5 replies - 1 through 5 (of 5 total)
  • Here’s a fix. It will be rolled out in the next update.

    In /includes/functions.php replace lines 371-373:

    OLD (remove)

        // setup the class for the link
        if ( $bsp_style_settings_buttons['button_type'] == 2 ) $class = $bsp_style_settings_buttons['Buttonclass'];
        else $class = 'bsp_button1';

    NEW (add)

        // setup the class for the link
        $class = 'bsp_button1';
        if ( ! empty( $bsp_style_settings_buttons['button_type'] ) && ! empty( $bsp_style_settings_buttons['Buttonclass'] ) ) {
                if ( $bsp_style_settings_buttons['button_type'] == 2 ) $class = $bsp_style_settings_buttons['Buttonclass'];
        }

    @robin-w – same kind of extra checks and changes should be added to functions:
    bsp_new_topic_button() (lines 305-306)
    bsp_unread button() (lines 318-319)
    bsp_display_reply_button() (lines 402-403)
    and bsp_profile_link() (lines 449-450).
    It’s happening when no values are present for button type and button class.

    @keith_saunders – I want to encourage you to disable displaying debug messages to the public on the frontend of your site. It can make your site vulnerable by revealing hacker-friendly information to people who don’t need to see it. Debug messages are very good and helpful, but can be a liability if not managed correctly.

    I recommend changing WP_DEBUG_DISPLAY to false, and using a plugin like DebugPress to select which user roles you want to be able to see debug information (ideally only admins).

    With a plugin like that, you can still see debug messages, but they’ll be in a pretty interface. You can always view the debug log directly, which is a good idea to do every once in a while (usually /wp-content/debug.log).

    • This reply was modified 3 years, 3 months ago by codejp3. Reason: edited for easier readability on functions to edit
    Plugin Author Robin W

    (@robin-w)

    @codejp3 I’ve added you as a committer – I am not in internet range to do an update – can you fix these ones in functions and release

    Thread Starter Keith_Saunders

    (@keith_saunders)

    Thank you very much for your feedback and very positive suggestion about using dedugpress which I have now installed and setup.

    I look forward to your formal update.

    Keith Saunders

    @keith_saunders – Formal 5.3.5 update released! Thank you for reporting the warning messages!

    Also thank you for your kind comments 🙂

    I’m marking as resolved, but let me know if you run into any other issues.

    @robin-w – I think I did everything right, but SVN can be a pain so let me know if I did something wrong with the release flow.

    Thread Starter Keith_Saunders

    (@keith_saunders)

    I can confirm that I have updated to your new 5.3.5 update and have not noted any issues so far.

    So, thank you again for your excellent work.

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Since update 2 days ago’ is closed to new replies.