WordPress.org

Forums

Our Team by WooThemes
Simple and sweet, but the code needs a tidy and some additions would be nice (4 posts)

  1. Oliver Needham
    Member
    Posted 2 years ago #

    It works as expected and is great, but there are a couple of additions that would make it 5*.

    The code the shortcode outputs is horrible. It used <pre> and <code> tags which are not useful at all.
    Also having widget as a CSS class in a page isn't usually good practice.

    I also don't understand why there is itemscope and itemtype="http://schema.org/Person" in the output.

    If you could change the taxonomy name that would be fantastic.

    For example this plugin would work great on a festival's website if we could change the 'team-member' term to 'artist' or a radio station's website if it could be changed to 'presenter'.

    Maybe the addition of a Facebook field would be beneficial in those situations, but as it is it works fantastically for other situations!

  2. James Koster
    Member
    Plugin Author

    Posted 2 years ago #

    Hey, thanks for the review.

    The code the shortcode outputs is horrible. It used

     and tags which are not useful at all.

    Hm, it shouldn't do. Maybe you added the shortcode in the 'visual' editor? Sometimes this wraps the shortcodes in pre tags for some reason.

    Also having widget as a CSS class in a page isn't usually good practice.

    That's debatable. The markup is the same as the widget. This means you can apply CSS to one class and it will hit all instances of the team output. Then you can use .sidebar or .content (or whatever) for specificity.

    I also don't understand why there is itemscope and itemtype="http://schema.org/Person" in the output.

    Have a read up on schema here.

    If you could change the taxonomy name that would be fantastic.

    You mean the post type name? You should be able to change the slugs by filtering woothemes_our_team_single_slug and woothemes_our_team_archive_slug. Still the same on the backend but that's not a big deal imo.

    Maybe the addition of a Facebook field would be beneficial in those situations, but as it is it works fantastically for other situations!

    You can easily add new fields as explained in the FAQ.

    Thanks again!

  3. Oliver Needham
    Member
    Posted 2 years ago #

    I've used lots of shortcodes from other plugs in visual view before and never found it a problem.

    You can see where I'm coming from though with the widget class though. To me it should only be there if it is a widget in a sidebar.

    I can see why you've used the Person schema, but personally I'm not bothered by it.

    If I change the post type name in the backend, what happens when you update the plugin? That will all disappear and break it. Wouldn't it be better to be able to change it in a field?

    And thanks for the FAQs, they're really useful :)

  4. James Koster
    Member
    Plugin Author

    Posted 2 years ago #

    Hey Oliver,

    Using shortcodes in the visual view isn't always an issue, it's just something I've seen before when pasting in code. Especially when copying from a plugins documentation for example, where the author might have wrapped the shortcode in code tags for illustration purposes.

    I see where you're coming from re .widget, but what happens if you have a widgetised region outside of the sidebar, IE in the header, or the footer? Or if you use the_widget() in a page template? Widgets are not exclusive to the sidebar imo.

    You don't have to touch the core files to change the slug. Like I said you can use the filter and add the code to your themes functions.php file.

    Glad you liked the FAQs :-)

Topic Closed

This topic has been closed to new replies.

About this Plugin

  • Our Team by WooThemes
  • Frequently Asked Questions
  • Support Threads
  • Reviews

About this Topic

Tags

No tags yet.