Hi Harm,
Would you be able to provide the URL of a page on which you have this implemented? You’d likely be able to resolve any styling issue you are facing with some simple custom CSS, and, if I can take a look at your page, I can hopefully suggest some CSS to help.
Thread Starter
Harm10
(@harm10)
No sorry. The live site I am using this plug-in on is still using the old version that easily supported excerpts (see my other report where I am reporting about the newly added filter).
It is fairly easy to see: the last part of the page that is built by the plug-in ends with that div I showed.
To make sure nothing added to the page by something else is confronted with a float “on” and hence displaying that something (in my case social media icons) directly to the right of this button is to add clear: both (or clear: left) to make sure.
Can you add this?
Obviously I can add custom css myself but I think the plug-in should leave the styling to default which is not float “on”.
In that case, you can try just adding some CSS that adds a clear to the containing div that control is in. For example:
#grfwp-pagination-controls {
clear: both;
}
Thread Starter
Harm10
(@harm10)
Although I think that such an addition should not be needed as the plug-in that puts a block of content including styling in part of the web page (as I use the shortcode) should also take care of all its changes done to the styling (and a active float is a particular for that) I will try your suggestion (because part of me doubts that this will have the desired effect as the clear should be set after the pagination controls) and report back.
In the meantime I will give you the following thought: suppose you had styled the Show More button to the right with a float for that, how would you imagine the rest of the web page following the shortcode output will look like?
I understand that you want the plugin to function, look and behave exactly as you imagine it should. And that’s what we want too. But we have many factors to consider. I’ve noted down for the developers every suggestion for improvement that you have made. And I can assure you that, when such a suggestion is reviewed, if it is in high demand and would be implementable without negatively impacting any other functionality in our plugin, that it will indeed be implemented. In the meantime, we can help you to adjust it, for example, with custom CSS, to get it closer to what you want/expect.
Thread Starter
Harm10
(@harm10)
I understand your reasoning and I also think it is good support.
As I suspected the css addition does not do the trick. Even when using :after.
The clear: both is then executed before the float itself.
If you change the code in template-functions.php to
<div id='grfwp-pagination-controls'>
<div id='grfwp-pagination-load-more' data-next_page='2'>
<?php _e( 'Show More', 'good-reviews-wp' ); ?>
</div>
<div id='clean_float' style='clear: both;'></div>
</div>
Then it works perfectly!
-
This reply was modified 2 years, 5 months ago by
Harm10.
