It is against the WordPress guidelines to offer credentials and it is not something we can or will accept. I just meant that, at this point, we need to be able to at least see this issue live. I understand you can’t make it live on your live site, which is why I’m wondering if it would be possible for you to clone the site to a test/dev site for us to have a look. Otherwise, it feels like we’re at an impasse.
Thread Starter
Harm10
(@harm10)
Let me ask you this: the button is working so the problem that started this report is gone. It was due to the fact that I included echo statements in the filter function.
Although I think that is weird still the button functions properly now (that the result is not what I expected is something else — and there is a different report for that).
So what is left are those notices in the log. You will not see those by just visiting a live site. Did I mention I am on PHP 7.4?
Maybe also important that I am using the filter function. I guess not a lot of users are already using that? You have it active on your site?
I can open up the test site for a planned moment then you can access it but still what do you want to analyze? If you want this please make a suggestion for a date and time (I am on Amsterdam time) and please tell me how I can give you the proper url (as I do not want to post it here)
Thread Starter
Harm10
(@harm10)
I would like to ask again whether the notices in my log (they keep on cropping up quite regularly) will be investigated?
PHP Notice: Undefined index: name in /myurl/wp-content/plugins/good-reviews-wp/includes/template-functions.php on line 611
PHP Notice: Undefined index: description in /myurl/wp-content/plugins/good-reviews-wp/includes/template-functions.php on line 612
PHP Notice: Undefined index: url in /myurl/wp-content/plugins/good-reviews-wp/includes/template-functions.php on line 613
Would you be able to explain a bit more regarding the button behaviour, pertaining to what you mention as expected and not expected behaviours? Regarding the notices, those values are from the website itself: the website Title, Tagline and URL from Settings -> General page of the WordPress. If you set those values, the notices should disappear.
Thread Starter
Harm10
(@harm10)
I am sorry to say that all 3 settings are set since installing WordPress years ago. So they have values. So I do not understand why template-functions.php seems to think that they are not set. Can you please explain? And can I expect the same notices on my live site as soon as I upgrade the plug-in when all problems are solved?
If you have installed the Five Star Business Profile and Schema plugin, there is an integration between these two plugins which overrides the default values of the $reviewed variable, via the filter grfwp_reviewed_values. You can check the respective values that filter looks for.
However, to remove those notices, you can set those values yourselves using that filter: grfwp_reviewed_values
-
This reply was modified 3 years, 10 months ago by
jaysupport.
Thread Starter
Harm10
(@harm10)
Forgive my ignorance…… But what is (or are) Five Star Business Profile and Schema plugin?
I am using the free version of Five Star Restaurant Reviews and not those mentioned above?
Hello Harm,
Our Business Profile and Schema plugin allows you to add schema structured data to any page and/or post type on your site and also to create a contact card to add all your business details with the correct structured data. You can read more about it here: https://wordpress.org/plugins/business-profile/
I was saying that, if you’re using that plugin, there is an integration between the two.
Either way, you should be able to use the aforementioned grfwp_reviewed_values hook to manually set the values yourself.
Thread Starter
Harm10
(@harm10)
As I am not using those plugins but am using the normal plugin isn’t it kind of strange that I need to set those values using a hook? The values are normally there so can be picked up or not? Why do you ask this of your users? Or is this a temporary fix?
What you’re seeing are PHP notices (not warnings or errors), which are only showing because you have debug enabled. What I’m saying is that, until we eliminate/correct the notices in an update, you should be able to eliminate them yourself by setting values using the hook.
Thread Starter
Harm10
(@harm10)
I know PHP notices do not break the code but they aren’t there for nothing!
Can you inform when you expect them to be fixed in an update?
Unfortunately I can’t. I don’t have a timeline for upcoming updates. But we’ll for sure look to take care of it in the next one.
Thread Starter
Harm10
(@harm10)
Do you want this report to remain Open until the next release?
Whichever you’d prefer. Leaving it open will not specifically help us in any way as we’ve already got this noted down internally.
