Support » Plugin: Popup Maker - Popup for opt-ins, lead gen, & more » Shortcodes not working anymore

  • Resolved chuantong

    (@chuantong)


    Hey, Popupmaker used to work great but after upgrading, shortcodes don’t work anymore in popups. I have some popups using Yoast Local SEO maps shortcode as well as Lightweight Grid Columns plugin shortcode. Neither one are working any longer.

    Many thanks in advance for your help.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Daniel Iser

    (@danieliser)

    @chuantong – Ultimately we may be at an impass. We have recently discovered that shortcodes were getting processed more than once for each popup. So forms that set the id of the form based on how many times it was rendered already no longer functioned correctly.

    This led to massive optimization of those processes.

    We have always processed shortcodes in wp_head, but up until recently those contents were ignored.

    Then shortcodes were reprocessed in the footer when the popup was rendered.

    Now we process them in the head (required for most form plugins to properly load assets), save that processed content and render it in the footer.

    What this likely means is the plugins you named are not properly registering their shortcodes in time (should be registered no later than init, though WordPress doesn’t suggest using any hook to add them, so they should be added as early as possible.

    This results in them not getting rendered.

    If you mean they render something other than [shortcode] or just emptiness, then it likely means their assets didn’t load for some reason.

    We obviously can’t leave inperformance code like that lingering, so we are not 100% what the right solution is gonna be going forward. Running it twice isn’t really an option, and some plugins refuse to work if we don’t call it in the footer only, others won’t work if we don’t call it in the head.

    One thing is we are moving everything to the new body_open hook, but this likely won’t cause shortcodes to work differently than they are already.

    Let me know.

    Thread Starter chuantong

    (@chuantong)

    Hi, thank you for your quick and precise answer. In the case of the two above mentioned plugin shortcodes i’m usring, i.e. Yoast and Lightweight Grid Columns, the output is an empty space.

    1) As Yoast is a major plugin, is there any plan to contact their developers so, if possible, they could make the change in their next release ?

    2) Would a downgrade to previous version of PopupMaker be an easy turn around in the meantime ? If yes, which version should work ?

    Thanks again for your help and great plugin.

    Plugin Author Daniel Iser

    (@danieliser)

    @chuantong – v1.8.6 should be fine.

    That said it’s generally faster for paid users to ask for help themselves rather than me doing it. IE your gonna get higher priority.

    If you drop us a ticket via https://wppopupmaker.com/support/ and send me a copy of the yoast plugin i’ll take a look and see what’s going on.

    Thread Starter chuantong

    (@chuantong)

    Hey, thank you, the downgrade to v.1.8.6 works fine.

    I didn’t get any answer yet from Lightweight Grid Columns support nor any solution from Yoast either. I’ll keep you posted i have ever get anything from them (I forwarded them your first answer with the details)

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Shortcodes not working anymore’ is closed to new replies.