Support » Plugin: Visualizer: Tables and Charts Manager for WordPress » Shortcode Attributes Removed Without Deprecation

  • Resolved daxelrod

    (@daxelrod)


    Between minor versions v3.4.4 and v3.4.5 shortcode attributes for ‘series’, ‘data’, and ‘settings’ were removed. I had been using those filters for a website and without even a mention in the CHANGELOG.md, they were removed without deprecation. Could we please have proper semver usage and complete changelog notes moving forward to alert of such changes?

    Below is the diff:

    
                    $atts = shortcode_atts(
                            array(
    -                               'id'     => false, // chart id
    -                               'class'  => false, // chart class
    -                               'series' => false, // series filter hook
    -                               'data'   => false, // data filter hook
    -                               'settings'   => false, // data filter hook
    +                               // chart id
    +                               'id'     => false,
    +                               // chart class
    +                               'class'  => false,
    +                               // for lazy load
    +                               // set 'yes' to use the default intersection limit (300px)
    +                               // OR set a number (e.g. 700) to use 700px as the intersection limit
    +                               'lazy' => apply_filters( 'visualizer_lazy_by_default', false, $atts['id'] ),
                            ),
                            $atts
                    );
    
Viewing 1 replies (of 1 total)
Viewing 1 replies (of 1 total)
  • The topic ‘Shortcode Attributes Removed Without Deprecation’ is closed to new replies.