Sharing buttons open two windows on Firefox since Jetpack 9.4

  • Resolved salubritas

    (@salubritas)


    3 years, 8 months ago

    Since updating to Jetpack 9.4, clicking on the sharing buttons for Twitter, Facebook and LinkedIn opens the sharing page in a new tab and also in a pop-up window. It should just open a pop-up window, not a new tab as well.

    This only happens in Firefox and only since 9.4. It does not happen in Chrome or Edge.

    The sharing buttons are underneath the post at the URL provided.

    • This topic was modified 3 years, 8 months ago by salubritas.

    The page I need help with: [log in to see the link]

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Contributor Dan (a11n)

    (@drawmyface)

    3 years, 8 months ago

    Hi there

    I was unable to see the issue on your site, but I was able to reproduce this issue on a test site. It seems to be quite intermittent and doesn’t happen every time.

    I’ve opened an issue here so our developers can investigate.

    https://github.com/Automattic/jetpack/issues/18760

    I’ll mark this resolved and you can follow that Github issue for updates.

    Plugin Author Jeremy Herve

    (@jeherve)

    Jetpack Mechanic 🚀

    3 years, 8 months ago

    Hi there!

    We’ve indeed made some changes to the Sharing feature in Jetpack 9.4. The feature previously relied on the jQuery library to add features such as the pop-ups. We’ve now moved away from that implementation, so the feature works faster.

    That said, I noticed that you use CloudFlare’ Rocket Loader feature on your site. I wonder if in some scenarios, this may impact the order and speed in which scripts are loaded on your site, thus impacting features that rely on JavaScript such as the sharing buttons.

    Could you try to deactivate that feature, and let me know if that helps?

    Thread Starter salubritas

    (@salubritas)

    3 years, 8 months ago

    @jeherve

    Hi, thanks for the reply.

    Deactivating Rocket Loader does not help.

    I first found this issue on my development environment with no Cloudflare or caching etc. of any sort. I have also tested with most plugins disabled.

    • This reply was modified 3 years, 8 months ago by salubritas.
    Thread Starter salubritas

    (@salubritas)

    3 years, 8 months ago

    @drawmyface

    That’s strange because I don’t find it to be intermittent at all. But as you have reproduced on a test site I will assume you have everything you need.

    Plugin Author Jeremy Herve

    (@jeherve)

    Jetpack Mechanic 🚀

    3 years, 8 months ago

    Thanks for giving it a try. We’ll dig into this some more, and try to fix this in a future version of Jetpack. As Dan mentioned above, we’ll update the linked GitHub issue when we make progress on this.

    Plugin Contributor Dan (a11n)

    (@drawmyface)

    3 years, 7 months ago

    To close the loop here, this was an issue with the button itself, and will be resolved in Jetpack 9.5 as per:
    https://github.com/Automattic/jetpack/issues/18760#issuecomment-776749033

    Thread Starter salubritas

    (@salubritas)

    3 years, 7 months ago

    Great, thank you.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Sharing buttons open two windows on Firefox since Jetpack 9.4’ is closed to new replies.