Title: Sharedaddy code improvements
Last modified: August 19, 2016

---

# Sharedaddy code improvements

 *  [Milan Dinić](https://wordpress.org/support/users/dimadin/)
 * (@dimadin)
 * [15 years, 6 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/)
 * I made a [patch](http://plugins.trac.wordpress.org/ticket/1240) with some improvements:
    - i18n of services’ names
    - filters for services’ names in links
    - missing textdomain from gettext function
    - filter for exclusion of custom post types
 * Filters for names of services are added because of languages that use cases, 
   where just translation of service’s name is not enough.
 * For example, in Serbian we can have _Подели ово: Фејсбук_ for _Share this: Facebook_,
   but we’ll have _Подели ово на: Фејсбуку_ for _Share this on: Facebook_.
 * Filter for post types is added because Sharedaddy uses is_single function so 
   if posts are chosen as option, it adds sharing on all post types except pages.
 * Note that we still won’t have post meta box for exclusion since post types are
   not supported well (it’s wpcom centric plugin).
 * Please include updated POT file in next release.

Viewing 13 replies - 1 through 13 (of 13 total)

 *  Plugin Author [John Godley](https://wordpress.org/support/users/johnny5/)
 * (@johnny5)
 * [15 years, 5 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779161)
 * Thanks dimadin, I’ll take a look at these and merge them in with the next version.
 *  [pmphilipps](https://wordpress.org/support/users/pmphilipps/)
 * (@pmphilipps)
 * [15 years, 5 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779189)
 * Hey! I use this nice plugin from yesterday. Ive notice a problem when using the
   email function. The email sended takes as adress [wordpress@domain.com](https://wordpress.org/support/topic/sharedaddy-code-improvements/wordpress@domain.com?output_format=md).
   
   Did you find how to change it with a fixed adress. I think it’s not interesting
   for the receiver to know the website system is a wordpress, i would prefer the
   ability to enter the sending adress in the parameters.
 * Best regards
 *  Plugin Author [John Godley](https://wordpress.org/support/users/johnny5/)
 * (@johnny5)
 * [15 years, 5 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779190)
 * You can use a plugin to change the default WordPress from address. For example:
 * [http://www.samburdge.co.uk/wordpress/wordpress-change-default-email-address-plugin](http://www.samburdge.co.uk/wordpress/wordpress-change-default-email-address-plugin)
 *  [pmphilipps](https://wordpress.org/support/users/pmphilipps/)
 * (@pmphilipps)
 * [15 years, 5 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779191)
 * Excellent!!!!!!
 * Thanks!!!
 *  [pmphilipps](https://wordpress.org/support/users/pmphilipps/)
 * (@pmphilipps)
 * [15 years, 5 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779194)
 * hm hm just didn’ find where are the f**** parameters? nope in tools either in
   settings?
 *  Thread Starter [Milan Dinić](https://wordpress.org/support/users/dimadin/)
 * (@dimadin)
 * [15 years, 5 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779196)
 * You didn’t read instructions:
 * > **Usage:**
    1. In the Plugins page in WordPress click the edit button next to the plugin in
       the list.
    2. Scroll down until you see a note saying ‘Configure it’
    3. Enter your name and email as shown
    4. If you don’t enter a new address the default ‘wordpress@’ will remain
 * If that is complicated for you, try [Mail From](http://code.andrewhamilton.net/wordpress/plugins/mail-from/).
 *  [pmphilipps](https://wordpress.org/support/users/pmphilipps/)
 * (@pmphilipps)
 * [15 years, 5 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779197)
 * Thanks Dimadin!!! Understood (this time) and done!!!
 * Best regards!
 * pM
 *  Thread Starter [Milan Dinić](https://wordpress.org/support/users/dimadin/)
 * (@dimadin)
 * [15 years, 4 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779279)
 * I made another patch, see more at [ticket](http://plugins.trac.wordpress.org/ticket/1240).
 *  [pmphilipps](https://wordpress.org/support/users/pmphilipps/)
 * (@pmphilipps)
 * [15 years, 4 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779280)
 * I! do you mean you made an update to the whole plugin?
    Happy New Year!
 *  Thread Starter [Milan Dinić](https://wordpress.org/support/users/dimadin/)
 * (@dimadin)
 * [15 years, 4 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779281)
 * No, I made a proposal for next update, here I’m just informing John about it.
 *  [deaf258](https://wordpress.org/support/users/deaf258/)
 * (@deaf258)
 * [15 years, 4 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779282)
 * The drag-n-drop of the buttons to enable it is not working.
 *  Plugin Author [John Godley](https://wordpress.org/support/users/johnny5/)
 * (@johnny5)
 * [15 years, 4 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779283)
 * Deaf258, how are they not working? What version of WordPress are you using? Do
   you have JavaScript enabled? Have you tried another browser? Do you have any 
   other plugins running that may be interfering with Sharedaddy?
 *  [deaf258](https://wordpress.org/support/users/deaf258/)
 * (@deaf258)
 * [15 years, 4 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779284)
 * Yeah, after the last comment here, I was playing around some more with some plugins
   and trying to see what works for me. It looks like one plugin is in conflict 
   with another plugin. I am trying to find out which one it is. I am using the 
   latest WordPress 3.0.4. I have Javascript enabled. I tried it on IE 8, FF 3.6.13
   and Chrome 8.0.552.224. I checked the debug and it said the js in that plugin
   hangs up everything else with javascript on the admin sharedaddy setting page.
   The WP admin sidebar expand buttons wouldn’t work only when I am on sharedaddy’s
   setting page. I tried disabling the plugins. Sharedaddy worked when it is the
   only plugin enabled. I am going to try completing my settings for sharedaddy 
   and see what happens when I turn on the plugins one at a time. Will keep you 
   posted.

Viewing 13 replies - 1 through 13 (of 13 total)

The topic ‘Sharedaddy code improvements’ is closed to new replies.

 * ![](https://s.w.org/plugins/geopattern-icon/sharedaddy.svg)
 * [Sharedaddy](https://wordpress.org/plugins/sharedaddy/)
 * [Support Threads](https://wordpress.org/support/plugin/sharedaddy/)
 * [Active Topics](https://wordpress.org/support/plugin/sharedaddy/active/)
 * [Unresolved Topics](https://wordpress.org/support/plugin/sharedaddy/unresolved/)
 * [Reviews](https://wordpress.org/support/plugin/sharedaddy/reviews/)

 * 13 replies
 * 4 participants
 * Last reply from: [deaf258](https://wordpress.org/support/users/deaf258/)
 * Last activity: [15 years, 4 months ago](https://wordpress.org/support/topic/sharedaddy-code-improvements/#post-1779284)
 * Status: not resolved