Support » Plugin: Woody ad snippets - Insert Header Footer Code, AdSense Ads » Serious Conflict with feature in Jetpack 6.1

  • dccharron

    (@dccharron)


    Many thanks for this excellent plugin.

    In case you don’t already know, the latest release of the Jetpack (6.1) plugin has created a rather serious conflict with your Insert PHP plugin (v1.3). I reported it to Jetpack and they’ve agreed that it’s a conflict. But they won’t fix it. They want you to fix your plugin.

    Refer to the post: https://wordpress.org/support/topic/inserted-php-fatal-error-in-version-6-1/#post-10247827

    If you read through the thread, it explains how Jetpack prevents Insert PHP from working (fatal error) when the inserted PHP code contains any “function”. It’s kind of hard to write any significant PHP code without using a “function”. So this conflict really limits what kind of PHP I can use with your plugin.

    Fortunately, I found a work-around by turning off a particular feature of Jetpack that I did not need (refer to the thread). However, the Jetpack author recommends I add a filter to bypass the error. The filter seems to be referring to another Jetpack tool/feature completely. I’m reluctant to follow his recommendation. I prefer to simply turn off the conflicting feature in Jetpack.

    The Jetpack author also recommendeds that I alert you to fix your plugin. I’m just the messenger.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author WillBontrager

    (@willbontrager)

    Thank you for reporting this. And I appreciate the messenger position you are experiencing.

    Actually, Insert PHP doesn’t need fixing. It works just fine, has done so for years. There are a few plugin authors who have create incompatibilities with Insert PHP for their users. However, it would be a never-ending rabbit hole and rather insane time sink to modify Insert PHP whenever someone else’s software introduces an incompatibility.

    A work-around to try: PHP code in an external file and using Insert PHP to include() the file.

    Jeremy Herve

    (@jeherve)

    Jetpack Mechanic πŸš€

    Hi Will!

    I work on the Jetpack plugin, and wanted to jump in on this and provide a bit more information about the issue, to clarify a few things.

    I believe the conflict is caused by the way you check for the presence of the insert-php shortcode in the post content:
    https://plugins.trac.wordpress.org/browser/insert-php/trunk/insert_php.php#L47

    While it works by itself, it can cause issues with other plugins that filter the_content, like Jetpack. You can read a bit more about a somewhat similar issue in this old thread, about a plugin that had similar issues a few years back:
    http://lists.automattic.com/pipermail/wp-hackers/2013-January/045053.html

    It may be an opportunity for you to switch to using WordPress’ shortcode API to handle your shortcode, thus solving conflicts with other plugins that filter the content, like Jetpack.

    I hope this clarifies things a bit!

    Plugin Author WillBontrager

    (@willbontrager)

    Hi Jeremy,

    Thank you for your information.

    I’m willing to see if I can get the same functionality using the shortcode API. It will be a fun little project.

    However, and this is a serious consideration because many people rely on Insert PHP, if it’s included in an Insert PHP update it must be backward compatible.

    A thought: Are you willing to take control of Insert PHP and its support with the stipulation that it remains available and that updates are backward compatible? My time is so very tight anymore.

    Will

    Jeremy Herve

    (@jeherve)

    Jetpack Mechanic πŸš€

    this is a serious consideration because many people rely on Insert PHP, if it’s included in an Insert PHP update it must be backward compatible.

    Of course. Using the shortcode API will not cause any compatibility issues, nothing will change in the way your users use the plugin. This codex page includes some examples to give you an idea on how to get started with this, if you’d like to give it a try:
    https://codex.wordpress.org/Shortcode_API

    A thought: Are you willing to take control of Insert PHP and its support with the stipulation that it remains available and that updates are backward compatible? My time is so very tight anymore.

    I don’t have the bandwidth for this right now either, I’m afraid! If you’d like to look for someone interested in taking the project over, I would recommend trying to use the Adopt me tag, as explained here:
    https://wptavern.com/adopt-me-plugin-tag-is-now-in-use-on-wordpress-org

    Plugin Author WillBontrager

    (@willbontrager)

    Jeremy, I appreciate very much the time you invested in this. Thank you for the information.

    Will

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Serious Conflict with feature in Jetpack 6.1’ is closed to new replies.