Support » Developing with WordPress » REST API documentation problem – Modifying responses – custom fields

  • Hi,

    I am really just wanting to highlight some confusing documentation I noticed while looking into registering custom endpoints for custom fields and post types.

    I am also not sure if this is where I should be reporting this, if some other forums is more proper, please advise.

    http://v2.wp-api.org/extending/modifying/
    Honestly I found this very clear, great examples, well laid out. But at the top there is a warning to go and use the developer handbook instead as this may be out of date…

    So I did
    https://developer.wordpress.org/rest-api/extending-the-rest-api/modifying-responses/#custom-fields

    But while this is fairly similar it is a lot less clear.

    It also seems to have included some cutting and pasting from the older resource, completely out of context.

    For example, at the bottom, this code:

    <?php
    // The object type. For custom post types, this is 'post';
    // for custom comment types, this is 'comment'. For user meta,
    // this is 'user'.
    $object_type = 'post';
    $args1 = array( // Validate and sanitize the meta value.
        // Note: currently (4.7) one of 'string', 'boolean', 'integer',
        // 'number' must be used as 'type'. The default is 'string'.
        'type'         => 'string',
        // Shown in the schema for the meta key.
        'description'  => 'A meta key associated with a string meta value.',
        // Return a single value of the type.
        'single'       => true,
        // Show in the WP REST API response. Default: false.
        'show_in_rest' => true,
    );
    register_meta( $object_type, 'my_meta_key', $args1 );

    has the accompanying text:

    This example shows how to allow reading and writing of a post meta field. This will allow the spaceship field to be updated via a POST request to wp-json/wp/v2/posts/<post-id> or created along with a post via a POST request to wp-json/wp/v2/posts/.

    However, the code in the developer handbook has no mention of a spaceship field, not anywhere on the modifying responses page in the developer handbook has any mention of said spaceship custom field….

    The spaceship custom field comes from the example on the old resource, as follows:

    add_action( 'rest_api_init', 'slug_register_starship' );
    function slug_register_starship() {
        register_rest_field( 'post',
            'starship',
            array(
                'get_callback'    => 'slug_get_starship',
                'update_callback' => null,
                'schema'          => null,
            )
        );
    }
    
    /**
     * Get the value of the "starship" field
     *
     * @param array $object Details of current post.
     * @param string $field_name Name of field.
     * @param WP_REST_Request $request Current request
     *
     * @return mixed
     */
    function slug_get_starship( $object, $field_name, $request ) {
        return get_post_meta( $object[ 'id' ], $field_name, true );
    }

    So I can only assume that the new developers handbook rest api documentation is pointing to an example in the old resource, that is suggesting that you should use the new resource, which doesn’t contain that example????

    Seems a bit messy.

    Jeff

Viewing 5 replies - 1 through 5 (of 5 total)
  • Moderator bcworkz

    (@bcworkz)

    Thank you for pointing out these issues. Unfortunately, the right people will unlikely see your post here without some prompting. I suggest you go to the #docs channel at wordpress.slack.com and ask for advice. Note that there are many places where documentation needs improvement and the Docs team always welcomes volunteers that want to help out 🙂

    @bcworkz

    Thanks, I will head over to the slack channel. It can be a bit difficult using slack from my location (China), but currently my VPN is holding up okay.

    I am happy to contribute some time to fixing this.

    Jeff

    Moderator bcworkz

    (@bcworkz)

    Awesome! If you keep having trouble with Slack, let me know and I’ll be happy to relay any initial information, but I think Docs volunteers (as with all WP teams) rely heavily on Slack to work together. I can’t speak for them, but one of the coordinators might be willing to communicate via email or something if need be.

    K. Adam White

    (@kadamwhite)

    Thanks very much for coming in to the #docs channel to raise this issue. I’ve gone through the https://developer.wordpress.org/rest-api/extending-the-rest-api/modifying-responses/ page and attempted to standardize and unify the documentation to reflect the updated content; it may be a little easier to understand, now, as well.

    We’re also open to receiving issues on our documentation at https://github.com/wp-api/docs-v2/issues but at present that issue queue is not regularly reviewed.

    Thanks for helping make this documentation better!

    Hey Adam,

    No problem, thanks for doing that. It is a little clearer, and your efforts are much appreciated.

    If I am having issues with slack in future, I’ll know to fall back to the github issues.

    Cheers again

    Jeff

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘REST API documentation problem – Modifying responses – custom fields’ is closed to new replies.